Refactoring: Add toWebFrameImpl() interface.

Refactoring: Add toWebFrameImpl() interface.

We should avoid static_cast at various places by using proper conversion function. This would avoid the error that can be introduced with each manual addition of static_cast addition. Unlike other toClassName functions (like in rendering), we do not require an assertion to confirm the type of passed WebFrame object, since WebFrameImpl is the only child class of WebFrame.

BUG=NONE
TEST=none; no behavior changes.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156825

[tkent, 2013-08-28 04:40:10]

lgtm

https://codereview.chromium.org/23671002/diff/2001/Source/web/tests/PopupMenu...
File Source/web/tests/PopupMenuTest.cpp (right):

https://codereview.chromium.org/23671002/diff/2001/Source/web/tests/PopupMenu...
Source/web/tests/PopupMenuTest.cpp:190: m_popupMenu = adoptRef(new
PopupMenuChromium(*(toWebFrameImpl(m_webView->mainFrame())->frame()),
&m_popupMenuClient));
You don't need to add ().

[tkent, 2013-08-28 04:42:13]

> Refactoring: Add toWebFrameImpl() & toConstWebFrameImpl() interfaces. 

Please update the description.

[r.kasibhatla, 2013-08-28 05:05:28]

On 2013/08/28 04:42:13, tkent wrote:
> > Refactoring: Add toWebFrameImpl() & toConstWebFrameImpl() interfaces. 
> 
> Please update the description.

Done.

[r.kasibhatla, 2013-08-28 05:05:41]

On 2013/08/28 04:40:10, tkent wrote:
> lgtm
> 
>
https://codereview.chromium.org/23671002/diff/2001/Source/web/tests/PopupMenu...
> File Source/web/tests/PopupMenuTest.cpp (right):
> 
>
https://codereview.chromium.org/23671002/diff/2001/Source/web/tests/PopupMenu...
> Source/web/tests/PopupMenuTest.cpp:190: m_popupMenu = adoptRef(new
> PopupMenuChromium(*(toWebFrameImpl(m_webView->mainFrame())->frame()),
> &m_popupMenuClient));
> You don't need to add ().
Done.

[tkent, 2013-08-28 05:06:29]

lgtm.  Thanks!

[commit-bot: I haz the power, 2013-08-28 05:06:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/23671002/7001

[commit-bot: I haz the power, 2013-08-28 07:07:46]

Change committed as 156825