Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2367003002: DevTools: allow passing command line flags into devtools front-end. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow passing command line flags into devtools front-end. BUG=649808 Committed: https://crrev.com/4258ecf058f31b9e0e25736c2da64e76a96b6758 Cr-Commit-Position: refs/heads/master@{#420790}

Patch Set 1 #

Patch Set 2 : same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
pfeldman
4 years, 3 months ago (2016-09-23 18:15:08 UTC) #2
dgozman
lgtm
4 years, 3 months ago (2016-09-23 21:14:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367003002/20001
4 years, 3 months ago (2016-09-23 21:19:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/74440)
4 years, 3 months ago (2016-09-23 21:30:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367003002/20001
4 years, 3 months ago (2016-09-23 22:54:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 23:42:07 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 23:46:06 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4258ecf058f31b9e0e25736c2da64e76a96b6758
Cr-Commit-Position: refs/heads/master@{#420790}

Powered by Google App Engine
This is Rietveld 408576698