Issue 23670009: fix regression in fallback chain where we don't account for the original font style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23670009: fix regression in fallback chain where we don't account for the original font style. (Closed)

Created:
7 years, 3 months ago by djsollen

Modified:
7 years, 3 months ago

Reviewers:
bungeman, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix regression in fallback chain where we don't account for the original font style. This CL also enforces that the language and variant are the same for all fonts within a given fallback family. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11128

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -29 lines)			Patch
	M	src/ports/SkFontConfigInterface_android.cpp	View		14 chunks	+47 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

djsollen

7 years, 3 months ago (2013-09-06 12:59:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r11128 (presubmit successful).

Expand Messages | Collapse Messages