cc: Handle deferred GL initialization failure.

cc/trees/layer_tree_host_impl_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <cmath>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 53 matching lines @@
  public:
   LayerTreeHostImplTest()
       : proxy_(),
         always_impl_thread_(&proxy_),
         always_main_thread_blocked_(&proxy_),
         on_can_draw_state_changed_called_(false),
         did_notify_ready_to_activate_(false),
         did_request_commit_(false),
         did_request_redraw_(false),
         did_upload_visible_tile_(false),
+        did_lose_output_surface_(false),
         reduce_memory_result_(true),
         current_limit_bytes_(0),
         current_priority_cutoff_value_(0) {
     media::InitializeMediaLibraryForTesting();
   }
 
   virtual void SetUp() OVERRIDE {
     LayerTreeSettings settings;
     settings.minimum_occlusion_tracking_size = gfx::Size();
     settings.impl_side_painting = true;
     settings.solid_color_scrollbars = true;
 
     host_impl_ = LayerTreeHostImpl::Create(settings,
                                            this,
                                            &proxy_,
                                            &stats_instrumentation_);
     host_impl_->InitializeRenderer(CreateOutputSurface());
     host_impl_->SetViewportSize(gfx::Size(10, 10));
   }
 
   virtual void TearDown() OVERRIDE {}
 
-  virtual void DidLoseOutputSurfaceOnImplThread() OVERRIDE {}
+  virtual void DidLoseOutputSurfaceOnImplThread() OVERRIDE {
+    did_lose_output_surface_ = true;
+  }
   virtual void OnSwapBuffersCompleteOnImplThread() OVERRIDE {}
   virtual void BeginFrameOnImplThread(const BeginFrameArgs& args)
       OVERRIDE {}
   virtual void OnCanDrawStateChanged(bool can_draw) OVERRIDE {
     on_can_draw_state_changed_called_ = true;
   }
   virtual void NotifyReadyToActivate() OVERRIDE {
     did_notify_ready_to_activate_ = true;
     host_impl_->ActivatePendingTree();
   }
@@ skipping 237 matching lines @@
   DebugScopedSetImplThread always_impl_thread_;
   DebugScopedSetMainThreadBlocked always_main_thread_blocked_;
 
   scoped_ptr<LayerTreeHostImpl> host_impl_;
   FakeRenderingStatsInstrumentation stats_instrumentation_;
   bool on_can_draw_state_changed_called_;
   bool did_notify_ready_to_activate_;
   bool did_request_commit_;
   bool did_request_redraw_;
   bool did_upload_visible_tile_;
+  bool did_lose_output_surface_;
   bool reduce_memory_result_;
   base::TimeDelta requested_scrollbar_animation_delay_;
   size_t current_limit_bytes_;
   int current_priority_cutoff_value_;
 };
 
 TEST_F(LayerTreeHostImplTest, NotifyIfCanDrawChanged) {
   bool always_draw = false;
   CheckNotifyCalledIfCanDrawChanged(always_draw);
 }
@@ skipping 5856 matching lines @@
 
   // Revert back to software.
   output_surface_ptr->ReleaseGL();
   EXPECT_FALSE(host_impl_->output_surface()->context_provider());
   EXPECT_FALSE(host_impl_->offscreen_context_provider());
 
   // Software draw again.
   DrawFrame();
 }
 
+TEST_F(LayerTreeHostImplTest, DeferredInitializeFails_OnscreenContext_0) {

[boliu, 2013/08/28 03:48:17]

output_surface_unittests should have a test similar to this, except of course it
can't dig into LTHI. Just fyi.

[danakj, 2013/08/28 15:36:09]

Ya, OutputSurfaceTestInitializeNewContext3d.ClientDeferredInitializeFails. But
it's testing different things. These are showing the LTHI doesn't crash as a
result and causes the lost surface.

+  set_reduce_memory_result(false);
+  scoped_ptr<FakeOutputSurface> output_surface(
+      FakeOutputSurface::CreateDeferredGL(
+          scoped_ptr<SoftwareOutputDevice>(new CountingSoftwareDevice())));
+  FakeOutputSurface* output_surface_ptr = output_surface.get();
+  EXPECT_TRUE(
+      host_impl_->InitializeRenderer(output_surface.PassAs<OutputSurface>()));
+
+  scoped_ptr<SolidColorLayerImpl> root_layer =
+      SolidColorLayerImpl::Create(host_impl_->active_tree(), 1);
+  SetupRootLayerImpl(root_layer.PassAs<LayerImpl>());
+
+  // Software draw.
+  DrawFrame();
+
+  scoped_refptr<TestContextProvider> onscreen_context_provider =
+      TestContextProvider::Create();
+  scoped_refptr<TestContextProvider> offscreen_context_provider =
+      TestContextProvider::Create();
+
+  // Fail initialization of the onscreen context before the OutputSurface binds
+  // it to the thread.
+  onscreen_context_provider->UnboundTestContext3d()
+      ->set_times_make_current_succeeds(0);
+
+  EXPECT_FALSE(host_impl_->output_surface()->context_provider());
+  EXPECT_FALSE(host_impl_->offscreen_context_provider());
+  EXPECT_FALSE(did_lose_output_surface_);
+
+  // DeferredInitialize fails.
+  EXPECT_FALSE(output_surface_ptr->InitializeAndSetContext3d(
+      onscreen_context_provider, offscreen_context_provider));
+  EXPECT_FALSE(host_impl_->output_surface()->context_provider());
+  EXPECT_FALSE(host_impl_->offscreen_context_provider());
+
+  // Software draw again.
+  DrawFrame();
+}
+
+TEST_F(LayerTreeHostImplTest, DeferredInitializeFails_OnscreenContext_1) {
+  set_reduce_memory_result(false);
+  scoped_ptr<FakeOutputSurface> output_surface(
+      FakeOutputSurface::CreateDeferredGL(
+          scoped_ptr<SoftwareOutputDevice>(new CountingSoftwareDevice())));
+  FakeOutputSurface* output_surface_ptr = output_surface.get();
+  EXPECT_TRUE(
+      host_impl_->InitializeRenderer(output_surface.PassAs<OutputSurface>()));
+
+  scoped_ptr<SolidColorLayerImpl> root_layer =
+      SolidColorLayerImpl::Create(host_impl_->active_tree(), 1);
+  SetupRootLayerImpl(root_layer.PassAs<LayerImpl>());
+
+  // Software draw.
+  DrawFrame();
+
+  scoped_refptr<TestContextProvider> onscreen_context_provider =
+      TestContextProvider::Create();
+  scoped_refptr<TestContextProvider> offscreen_context_provider =
+      TestContextProvider::Create();
+
+  // Fail initialization of the onscreen context after the OutputSurface binds
+  // it to the thread.
+  onscreen_context_provider->UnboundTestContext3d()
+      ->set_times_make_current_succeeds(2);
+
+  EXPECT_FALSE(host_impl_->output_surface()->context_provider());
+  EXPECT_FALSE(host_impl_->offscreen_context_provider());
+  EXPECT_FALSE(did_lose_output_surface_);
+
+  // DeferredInitialize fails.
+  EXPECT_FALSE(output_surface_ptr->InitializeAndSetContext3d(
+      onscreen_context_provider, offscreen_context_provider));
+  EXPECT_FALSE(host_impl_->output_surface()->context_provider());
+  EXPECT_FALSE(host_impl_->offscreen_context_provider());
+
+  // We lose the output surface.
+  EXPECT_TRUE(did_lose_output_surface_);
+}
+
+TEST_F(LayerTreeHostImplTest, DeferredInitializeFails_OnscreenContext_2) {
+  set_reduce_memory_result(false);
+  scoped_ptr<FakeOutputSurface> output_surface(
+      FakeOutputSurface::CreateDeferredGL(
+          scoped_ptr<SoftwareOutputDevice>(new CountingSoftwareDevice())));
+  FakeOutputSurface* output_surface_ptr = output_surface.get();
+  EXPECT_TRUE(
+      host_impl_->InitializeRenderer(output_surface.PassAs<OutputSurface>()));
+
+  scoped_ptr<SolidColorLayerImpl> root_layer =
+      SolidColorLayerImpl::Create(host_impl_->active_tree(), 1);
+  SetupRootLayerImpl(root_layer.PassAs<LayerImpl>());
+
+  // Software draw.
+  DrawFrame();
+
+  scoped_refptr<TestContextProvider> onscreen_context_provider =
+      TestContextProvider::Create();
+  scoped_refptr<TestContextProvider> offscreen_context_provider =
+      TestContextProvider::Create();
+
+  // Fail initialization of the onscreen context after the OutputSurface binds
+  // it to the thread and during renderer initialization.
+  onscreen_context_provider->UnboundTestContext3d()
+      ->set_times_make_current_succeeds(1);
+
+  EXPECT_FALSE(host_impl_->output_surface()->context_provider());
+  EXPECT_FALSE(host_impl_->offscreen_context_provider());
+  EXPECT_FALSE(did_lose_output_surface_);
+
+  // DeferredInitialize fails.
+  EXPECT_FALSE(output_surface_ptr->InitializeAndSetContext3d(
+      onscreen_context_provider, offscreen_context_provider));
+  EXPECT_FALSE(host_impl_->output_surface()->context_provider());
+  EXPECT_FALSE(host_impl_->offscreen_context_provider());
+
+  // We lose the output surface.
+  EXPECT_TRUE(did_lose_output_surface_);
+}
+
+TEST_F(LayerTreeHostImplTest, DeferredInitializeFails_OffscreenContext) {

[boliu, 2013/08/28 03:48:17]

Load of duplicated code between these 4 tests. Everything above
set_times_make_current_succeeds and the expectations before initialize. Refactor
into a fixture class?

[danakj, 2013/08/28 15:36:09]

Sure!

+  set_reduce_memory_result(false);
+  scoped_ptr<FakeOutputSurface> output_surface(
+      FakeOutputSurface::CreateDeferredGL(
+          scoped_ptr<SoftwareOutputDevice>(new CountingSoftwareDevice())));
+  FakeOutputSurface* output_surface_ptr = output_surface.get();
+  EXPECT_TRUE(
+      host_impl_->InitializeRenderer(output_surface.PassAs<OutputSurface>()));
+
+  scoped_ptr<SolidColorLayerImpl> root_layer =
+      SolidColorLayerImpl::Create(host_impl_->active_tree(), 1);
+  SetupRootLayerImpl(root_layer.PassAs<LayerImpl>());
+
+  // Software draw.
+  DrawFrame();
+
+  scoped_refptr<TestContextProvider> onscreen_context_provider =
+      TestContextProvider::Create();
+  scoped_refptr<TestContextProvider> offscreen_context_provider =
+      TestContextProvider::Create();
+
+  // Fail initialization of the offscreen context.
+  offscreen_context_provider->UnboundTestContext3d()
+      ->set_times_make_current_succeeds(0);
+
+  EXPECT_FALSE(host_impl_->output_surface()->context_provider());
+  EXPECT_FALSE(host_impl_->offscreen_context_provider());
+  EXPECT_FALSE(did_lose_output_surface_);
+
+  // DeferredInitialize fails.
+  EXPECT_FALSE(output_surface_ptr->InitializeAndSetContext3d(
+      onscreen_context_provider, offscreen_context_provider));
+  EXPECT_FALSE(host_impl_->output_surface()->context_provider());
+  EXPECT_FALSE(host_impl_->offscreen_context_provider());
+
+  // We lose the output surface.
+  EXPECT_TRUE(did_lose_output_surface_);
+}
+
 class ContextThatDoesNotSupportMemoryManagmentExtensions
     : public TestWebGraphicsContext3D {
  public:
   // WebGraphicsContext3D methods.
   virtual WebKit::WebString getString(WebKit::WGC3Denum name) {
     return WebKit::WebString();
   }
 };
 
 // Checks that we have a non-0 default allocation if we pass a context that
@@ skipping 75 matching lines @@
   EXPECT_EQ(0u, host_impl_->ResourceIdForUIResource(ui_resource_id));
   EXPECT_EQ(0u, context3d->NumTextures());
 
   // Should not change state for multiple deletion on one UIResourceId
   host_impl_->DeleteUIResource(ui_resource_id);
   EXPECT_EQ(0u, context3d->NumTextures());
 }
 
 }  // namespace
 }  // namespace cc