[turbofan] Attach source positions to deopt info.

[turbofan] Attach source positions to deopt info.

R=bmeurer@chromium.org,jarin@chromium.org
BUG=

Committed: https://crrev.com/7617705d073a86feb241f946b967d5c794830255
Cr-Commit-Position: refs/heads/master@{#39733}

[Benedikt Meurer, 2016-09-23 18:15:43]

Description was changed from

==========
[turbofan] attach source positions to deopt info

R=bmeurer@chromium.org

BUG=
==========

to

==========
[turbofan] Attach source positions to deopt info.

R=bmeurer@chromium.org,jarin@chromium.org
BUG=
==========

[Benedikt Meurer, 2016-09-23 18:15:43]

bmeurer@chromium.org changed reviewers:
+ jarin@chromium.org

[Benedikt Meurer, 2016-09-23 18:21:37]

bmeurer@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Benedikt Meurer, 2016-09-23 18:21:37]

bmeurer@chromium.org changed required reviewers:
+ mstarzinger@chromium.org

[Benedikt Meurer, 2016-09-23 18:21:37]

LGTM from my side, adding Michi (and Jaro) for review on source position use.

https://codereview.chromium.org/2366993002/diff/1/src/compiler/code-generator...
File src/compiler/code-generator-impl.h (right):

https://codereview.chromium.org/2366993002/diff/1/src/compiler/code-generator...
src/compiler/code-generator-impl.h:183: SourcePosition pos_;
Nit: make this const as well.

[Michael Starzinger, 2016-09-26 11:53:37]

LGTM, because this is v8::internal::compiler::SourcePosition which is fine for
internal compiler use, we should just watch out to not introduce uses of
v8::internal::SourcePosition in TurboFan.

[Tobias Tebbi, 2016-09-26 13:56:35]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2016-09-26 13:56:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2366993002/#ps20001
(title: "DeoptimizationExit::pos_ made const")

[commit-bot: I haz the power, 2016-09-26 13:56:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 14:23:35]

Description was changed from

==========
[turbofan] Attach source positions to deopt info.

R=bmeurer@chromium.org,jarin@chromium.org
BUG=
==========

to

==========
[turbofan] Attach source positions to deopt info.

R=bmeurer@chromium.org,jarin@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-09-26 14:23:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-26 14:23:47]

Description was changed from

==========
[turbofan] Attach source positions to deopt info.

R=bmeurer@chromium.org,jarin@chromium.org
BUG=
==========

to

==========
[turbofan] Attach source positions to deopt info.

R=bmeurer@chromium.org,jarin@chromium.org
BUG=

Committed: https://crrev.com/7617705d073a86feb241f946b967d5c794830255
Cr-Commit-Position: refs/heads/master@{#39733}
==========

[commit-bot: I haz the power, 2016-09-26 14:23:48]

Patchset 2 (id:??) landed as
https://crrev.com/7617705d073a86feb241f946b967d5c794830255
Cr-Commit-Position: refs/heads/master@{#39733}