Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2366973003: Include libosmesa.so in blimp engine test bundle. (Closed)

Created:
4 years, 3 months ago by markellis
Modified:
4 years, 2 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include libosmesa.so in blimp engine test bundle. libosmesa.so is referenced in blimp/engine/browser_tests/integration_test.cc:68 This is a temporary workaround for crbug.com/650285 Also, add tests-manifest-blacklist.txt as an input to generate_blimp_engine_env_tests_manifest, so that when the blacklist changes the test bundle is re-generated. R=dtrainor@chromium.org BUG=650285 Committed: https://crrev.com/dd5278dd455874004f3caad669422daeaa03fbf0 Cr-Commit-Position: refs/heads/master@{#421286}

Patch Set 1 #

Patch Set 2 : Include libosmesa.so in blimp engine test bundle. #

Patch Set 3 : Include libosmesa.so in blimp engine test bundle. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M blimp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/tools/tests-manifest-blacklist.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
David Trainor- moved to gerrit
lgtm. I can revert this if/when I fix the dependency issue.
4 years, 3 months ago (2016-09-23 23:46:36 UTC) #1
maniscalco
On 2016/09/23 23:46:36, David Trainor wrote: > lgtm. I can revert this if/when I fix ...
4 years, 3 months ago (2016-09-23 23:51:26 UTC) #2
markellis
On 2016/09/23 23:51:26, maniscalco wrote: > On 2016/09/23 23:46:36, David Trainor wrote: > > lgtm. ...
4 years, 2 months ago (2016-09-26 16:15:46 UTC) #5
maniscalco
On 2016/09/26 16:15:46, markellis wrote: > On 2016/09/23 23:51:26, maniscalco wrote: > > On 2016/09/23 ...
4 years, 2 months ago (2016-09-26 16:16:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366973003/40001
4 years, 2 months ago (2016-09-27 16:34:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-27 18:59:43 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 19:05:21 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dd5278dd455874004f3caad669422daeaa03fbf0
Cr-Commit-Position: refs/heads/master@{#421286}

Powered by Google App Engine
This is Rietveld 408576698