LayoutTests/fast/html/script-tests/aside-element.js - Issue 236693002: Replace Selection.collapse() with Selection.removeAllRanges() in layout tests..

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/html/script-tests/aside-element.js

Issue 236693002: Replace Selection.collapse() with Selection.removeAllRanges() in layout tests.. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/html/script-tests/aside-element.js

diff --git a/LayoutTests/fast/html/script-tests/aside-element.js b/LayoutTests/fast/html/script-tests/aside-element.js

index 1119440a7ab7ddce0d2c8b95e2a75863bc655df3..573b78427bbb671f14d99a7698d64a3b998a3413 100644

--- a/LayoutTests/fast/html/script-tests/aside-element.js

+++ b/LayoutTests/fast/html/script-tests/aside-element.js

@@ -35,7 +35,7 @@ editable.contentEditable = true;

var selection = window.getSelection();

selection.selectAllChildren(editable);

document.execCommand('FormatBlock', false, 'aside');

-selection.collapse();

+selection.removeAllRanges();

shouldBe('document.getElementById("span2").parentNode.nodeName', '"ASIDE"');

document.body.removeChild(editable);

« no previous file with comments | « LayoutTests/fast/html/script-tests/article-element.js ('k') | LayoutTests/fast/html/script-tests/footer-element.js » ('j') | no next file with comments »