LayoutTests/editing/execCommand/overtype.html - Issue 236693002: Replace Selection.collapse() with Selection.removeAllRanges() in layout tests..

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/execCommand/overtype.html

Issue 236693002: Replace Selection.collapse() with Selection.removeAllRanges() in layout tests.. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/editing/execCommand/overtype.html

diff --git a/LayoutTests/editing/execCommand/overtype.html b/LayoutTests/editing/execCommand/overtype.html

index 50431408afc61ea92d8e3d74282c49c0203f25c4..ed3de558afe4f7fd8fc2e34c9afb38f7d037c666 100644

--- a/LayoutTests/editing/execCommand/overtype.html

+++ b/LayoutTests/editing/execCommand/overtype.html

@@ -1,4 +1,4 @@

-<!DOCTYPE html>

+<!DOCTYPE html>

<html>

<head>

@@ -63,7 +63,7 @@ else {

Markup.dump(element, 'Overwrite behaves like insert on range selections');

element.innerHTML = "丠両丢丣";

- selection.collapse();

+ selection.removeAllRanges();

Markup.dump(element, 'New CJK contents');

selection.collapse(element, 0);

@@ -71,7 +71,7 @@ else {

Markup.dump(element, 'Overwrite CJK text');

element.innerHTML="<div id=\"rtl-div\" dir=\"rtl\">&aleph;&beth;&gimel;&daleth;</div>"

- selection.collapse();

+ selection.removeAllRanges();

Markup.dump(element, 'New RTL contents');

selection.collapse(element, 0);

« no previous file with comments | « no previous file | LayoutTests/fast/html/nav-element.html » ('j') | no next file with comments »