Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2366903003: Revert of [api] Clean up scopes and precheck instantiations cache (Closed)

Created:
4 years, 3 months ago by Camillo Bruni
Modified:
4 years, 3 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [api] Clean up scopes and precheck instantiations cache (patchset #3 id:40001 of https://codereview.chromium.org/2206773003/ ) Reason for revert: Regresses API see go/v8-startup-api Original issue's description: > [api] Clean up scopes and precheck instantiations cache > > Make sure all the scopes used in api-natives.cc have inlineable constructors > and destructors. Additionally directly precheck the instantiations cache before > trying to enter the InvokeScope which sets the save_context. > > BUG=chromium:630217 > > Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5 > Cr-Commit-Position: refs/heads/master@{#38346} TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:630217, chromium:635912 Committed: https://crrev.com/85575cd8ee33fa3dd49ffc58de6e0b958df29094 Cr-Commit-Position: refs/heads/master@{#39680}

Patch Set 1 #

Patch Set 2 : resolving merge conflicts #

Patch Set 3 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -76 lines) Patch
M src/api-natives.cc View 1 2 7 chunks +27 lines, -58 lines 0 comments Download
M src/isolate.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M src/isolate-inl.h View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Camillo Bruni
Created Revert of [api] Clean up scopes and precheck instantiations cache
4 years, 3 months ago (2016-09-23 12:22:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366903003/120001
4 years, 3 months ago (2016-09-23 13:49:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24880)
4 years, 3 months ago (2016-09-23 13:58:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366903003/120001
4 years, 3 months ago (2016-09-23 15:31:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366903003/140001
4 years, 3 months ago (2016-09-23 15:32:54 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:140001)
4 years, 3 months ago (2016-09-23 16:01:27 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 16:01:42 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/85575cd8ee33fa3dd49ffc58de6e0b958df29094
Cr-Commit-Position: refs/heads/master@{#39680}

Powered by Google App Engine
This is Rietveld 408576698