Issue 23669007: Prepare push to trunk. Now working on version 3.21.18.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23669007: Prepare push to trunk. Now working on version 3.21.18. (Closed)

Created:
7 years, 3 months ago by Hannes Payer (out of office)

Modified:
7 years, 3 months ago

Reviewers:
Michael Achenbach, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.21.18. R=machenbach@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16780

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+17 lines, -0 lines	1 comment	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

On 2013/09/18 06:04:54, Hannes Payer wrote: lgtm

7 years, 3 months ago (2013-09-18 06:55:04 UTC) #2

Hannes Payer (out of office)

Committed patchset #2 manually as r16780 (presubmit successful).

7 years, 3 months ago (2013-09-18 07:44:25 UTC) #3

Jakob Kummerow

7 years, 3 months ago (2013-09-18 18:05:30 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/23669007/diff/3001/ChangeLog
File ChangeLog (right):

https://codereview.chromium.org/23669007/diff/3001/ChangeLog#newcode13
ChangeLog:13: (Chromium issue 2881)
nit: this is clearly a V8 issue number.

Expand Messages | Collapse Messages