Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2366893003: fix msan bug in pathops (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix msan bug in pathops Msan and Valgrind found an uninitialized memory mistake in pathops. This also fixes similar bugs where not all parts of the geometry were covered in the loop iteration. R=borenet@google.com NOTREECHECKS=true GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366893003 Committed: https://skia.googlesource.com/skia/+/cc09372730301be78b9d26c1198db1584622cdd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/pathops/SkOpEdgeBuilder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/pathops/SkPathOpsCurve.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
caryclark
4 years, 3 months ago (2016-09-23 16:01:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366893003/1
4 years, 3 months ago (2016-09-23 16:02:02 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-23 16:02:04 UTC) #5
borenet
LGTM with the caveat that I've never seen this code before.
4 years, 3 months ago (2016-09-23 16:07:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366893003/1
4 years, 3 months ago (2016-09-23 16:31:22 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 16:32:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cc09372730301be78b9d26c1198db1584622cdd9

Powered by Google App Engine
This is Rietveld 408576698