Invalidate paint of FrameView before invalidating the layout tree

Invalidate paint of FrameView before invalidating the layout tree

This makes the current path and the slimmingPaintInvalidation path
invalidate FrameView and layout tree in the same order, to avoid
unnecessary layout test result differences. The slimmingPaintInvalidation
path needs to handle invalidation of FrameView before traversing into
the layout tree because the former initializes PaintInvalidatorContext
which is needed by the latter.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176
Committed: https://crrev.com/26ed6abea304672af3341109f6307d4001ed7bc4
Cr-Commit-Position: refs/heads/master@{#420749}

[Xianzhu, 2016-09-23 03:39:31]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 03:39:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-23 03:50:42]

Description was changed from

==========
Invalidate paint of FrameView before the layout tree

This makes the old path and slimmingPaintInvalidation path invalidate
FrameView and layout tree in the same order, to avoid unnecessary
layout test result differences.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176
==========

to

==========
Invalidate paint of FrameView before invalidating the layout tree

This makes the old path and slimmingPaintInvalidation path invalidate
FrameView and layout tree in the same order, to avoid unnecessary
layout test result differences.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176
==========

[commit-bot: I haz the power, 2016-09-23 04:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 04:44:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-09-23 05:51:12]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 05:51:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 07:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 07:42:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-09-23 15:35:35]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 15:35:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-23 15:37:05]

Description was changed from

==========
Invalidate paint of FrameView before invalidating the layout tree

This makes the old path and slimmingPaintInvalidation path invalidate
FrameView and layout tree in the same order, to avoid unnecessary
layout test result differences.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176
==========

to

==========
Invalidate paint of FrameView before invalidating the layout tree

This makes the current path and the slimmingPaintInvalidation path
invalidate FrameView and layout tree in the same order, to avoid
unnecessary layout test result differences. The slimmingPaintInvalidation
path needs to handle invalidation of FrameView before traversing into
the layout tree because the former initializes PaintInvalidatorContext
which is needed by the latter.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176
==========

[Xianzhu, 2016-09-23 15:37:19]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-09-23 17:13:01]

https://codereview.chromium.org/2366853002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2366853002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:267: crbug.com/646176
paint/invalidation/4776765.html [ NeedsRebaseline ]
Maybe we should start using the new method of rebaselining in our code reviews:

(from Quinten's email)

Upload your CL.
Trigger Blink try jobs.
The try bots to use are the blink try bots that end in blink_rel. This can be
done via the Rietveld UI or git cl try.
Wait for the try jobs to finish.
Run webkit-patch rebaseline-cl to fetch new baselines.
Commit the new baselines and upload a new patch.

[Xianzhu, 2016-09-23 17:54:44]

https://codereview.chromium.org/2366853002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2366853002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:267: crbug.com/646176
paint/invalidation/4776765.html [ NeedsRebaseline ]
On 2016/09/23 17:13:01, chrishtr wrote:
> Maybe we should start using the new method of rebaselining in our code
reviews:
> 
> (from Quinten's email)
> 
> Upload your CL.
> Trigger Blink try jobs.
> The try bots to use are the blink try bots that end in blink_rel. This can be
> done via the Rietveld UI or git cl try.
> Wait for the try jobs to finish.
> Run webkit-patch rebaseline-cl to fetch new baselines.
> Commit the new baselines and upload a new patch.

Running try jobs.

(I know the new method but it needs more manual steps than the rebaseline-bot
method. Perhaps we should put some effort to automate the new method.)

[chrishtr, 2016-09-23 17:56:38]

Quinten is working on that.

[commit-bot: I haz the power, 2016-09-23 18:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 18:56:08]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-09-23 21:55:23]

Unable to run webkit-patch rebaseline-cl because there are other unrelated
NeedsRebaselines in TestExpectations, and the script raise an error when
rebaseline the unrelated NeedsRebaselines.

[chrishtr, 2016-09-23 21:56:29]

lgtm

[Xianzhu, 2016-09-23 21:57:47]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:58:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:40:12]

Description was changed from

==========
Invalidate paint of FrameView before invalidating the layout tree

This makes the current path and the slimmingPaintInvalidation path
invalidate FrameView and layout tree in the same order, to avoid
unnecessary layout test result differences. The slimmingPaintInvalidation
path needs to handle invalidation of FrameView before traversing into
the layout tree because the former initializes PaintInvalidatorContext
which is needed by the latter.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176
==========

to

==========
Invalidate paint of FrameView before invalidating the layout tree

This makes the current path and the slimmingPaintInvalidation path
invalidate FrameView and layout tree in the same order, to avoid
unnecessary layout test result differences. The slimmingPaintInvalidation
path needs to handle invalidation of FrameView before traversing into
the layout tree because the former initializes PaintInvalidatorContext
which is needed by the latter.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176
==========

[commit-bot: I haz the power, 2016-09-23 22:40:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 22:42:31]

Description was changed from

==========
Invalidate paint of FrameView before invalidating the layout tree

This makes the current path and the slimmingPaintInvalidation path
invalidate FrameView and layout tree in the same order, to avoid
unnecessary layout test result differences. The slimmingPaintInvalidation
path needs to handle invalidation of FrameView before traversing into
the layout tree because the former initializes PaintInvalidatorContext
which is needed by the latter.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176
==========

to

==========
Invalidate paint of FrameView before invalidating the layout tree

This makes the current path and the slimmingPaintInvalidation path
invalidate FrameView and layout tree in the same order, to avoid
unnecessary layout test result differences. The slimmingPaintInvalidation
path needs to handle invalidation of FrameView before traversing into
the layout tree because the former initializes PaintInvalidatorContext
which is needed by the latter.

This will change the order of object paint invalidation of caret and
frame scrollbars. In some cases, this will cause the caret to be
invalidated twice (one in FrameView, another in BlockPaintInvalidator).
Will optimize this when making partial rect invalidation work for spv2.

BUG=646176

Committed: https://crrev.com/26ed6abea304672af3341109f6307d4001ed7bc4
Cr-Commit-Position: refs/heads/master@{#420749}
==========

[commit-bot: I haz the power, 2016-09-23 22:42:32]

Patchset 3 (id:??) landed as
https://crrev.com/26ed6abea304672af3341109f6307d4001ed7bc4
Cr-Commit-Position: refs/heads/master@{#420749}