Fix two Chrome Apps browser tests with PlzNavigate.

Fix two Chrome Apps browser tests with PlzNavigate.

PolicyTest.FullscreenAllowedApp: after r349290, the ScriptContext is delayed until navigation commits. So the test has to wait for navigation first before executing the JS in the app, or else it fails because the chrome app bindings aren't registered yet.

AppWindowAPITest.TestCreate: the badWindow part of this test isn't compatible with PlzNavigate. Or more specifically, the condition isn't possible with it. Without PlzNavigate, creating an app window with an invalid URL would first create that frame with the provisional load URL of the chrome app. So the chrome apps ScriptContext would be setup correctly and view.chrome.app.window.initializeAppWindow would be called with an undefined window. However with PlzNavigate, the frame isn't created until after the navigation commits. At that point, we know that it failed and the URL of the frame becomes the error page url, and as such the chrome apps ScriptContext isn't used since the (error page) url isn't an extension. This can't even be fixed by adding a null check in app_window_custom_bindings.js because the security origin of the background page and the error page is different so Blink disallows the scripting call.

BUG=504347
Committed: https://crrev.com/2637dd1897b41b795196119e96606501a6c983a5
Cr-Commit-Position: refs/heads/master@{#420631}

[jam, 2016-09-23 02:21:15]

Patchset #1 (id:1) has been deleted

[jam, 2016-09-23 02:21:46]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 02:22:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-09-23 02:24:02]

jam@chromium.org changed reviewers:
+ rockot@chromium.org

[jam, 2016-09-23 02:24:02]

(Devlin is OOO so you get the patch)

[commit-bot: I haz the power, 2016-09-23 03:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:15:59]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-09-23 16:32:07]

lgtm

[jam, 2016-09-23 16:33:32]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-09-23 16:33:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:39:39]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-23 16:42:45]

Description was changed from

==========
Fix two Chrome Apps browser tests with PlzNavigate.

PolicyTest.FullscreenAllowedApp: after r349290, the ScriptContext is delayed
until navigation commits. So the test has to wait for navigation first before
executing the JS in the app, or else it fails because the chrome app bindings
aren't registered yet.

AppWindowAPITest.TestCreate: the badWindow part of this test isn't compatible
with PlzNavigate. Or more specifically, the condition isn't possible with it.
Without PlzNavigate, creating an app window with an invalid URL would first
create that frame with the provisional load URL of the chrome app. So the chrome
apps ScriptContext would be setup correctly and
view.chrome.app.window.initializeAppWindow would be called with an undefined
window. However with PlzNavigate, the frame isn't created until after the
navigation commits. At that point, we know that it failed and the URL of the
frame becomes the error page url, and as such the chrome apps ScriptContext
isn't used since the (error page) url isn't an extension. This can't even be
fixed by adding a null check in app_window_custom_bindings.js because the
security origin of the background page and the error page is different so Blink
disallows the scripting call.

BUG=504347
==========

to

==========
Fix two Chrome Apps browser tests with PlzNavigate.

PolicyTest.FullscreenAllowedApp: after r349290, the ScriptContext is delayed
until navigation commits. So the test has to wait for navigation first before
executing the JS in the app, or else it fails because the chrome app bindings
aren't registered yet.

AppWindowAPITest.TestCreate: the badWindow part of this test isn't compatible
with PlzNavigate. Or more specifically, the condition isn't possible with it.
Without PlzNavigate, creating an app window with an invalid URL would first
create that frame with the provisional load URL of the chrome app. So the chrome
apps ScriptContext would be setup correctly and
view.chrome.app.window.initializeAppWindow would be called with an undefined
window. However with PlzNavigate, the frame isn't created until after the
navigation commits. At that point, we know that it failed and the URL of the
frame becomes the error page url, and as such the chrome apps ScriptContext
isn't used since the (error page) url isn't an extension. This can't even be
fixed by adding a null check in app_window_custom_bindings.js because the
security origin of the background page and the error page is different so Blink
disallows the scripting call.

BUG=504347

Committed: https://crrev.com/2637dd1897b41b795196119e96606501a6c983a5
Cr-Commit-Position: refs/heads/master@{#420631}
==========

[commit-bot: I haz the power, 2016-09-23 16:42:46]

Patchset 1 (id:??) landed as
https://crrev.com/2637dd1897b41b795196119e96606501a6c983a5
Cr-Commit-Position: refs/heads/master@{#420631}