Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: Source/devtools/front_end/TimelinePanel.js

Issue 236683006: TimelinePanel: REGRESSION apply window filter to the search results (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelinePanel.js
diff --git a/Source/devtools/front_end/TimelinePanel.js b/Source/devtools/front_end/TimelinePanel.js
index ffb690dec1a3a98f7fbb8ac588d1dba2b57e20d7..f6913d325c1779328e03fbdf057580c0fc673afa 100644
--- a/Source/devtools/front_end/TimelinePanel.js
+++ b/Source/devtools/front_end/TimelinePanel.js
@@ -819,13 +819,17 @@ WebInspector.TimelinePanel.prototype = {
/**
* @param {!WebInspector.TimelineModel.Record} record
+ * @this {WebInspector.TimelinePanel}
*/
function processRecord(record)
{
+ if (record.endTime < this._windowStartTime ||
+ record.startTime > this._windowEndTime)
+ return;
if (record.testContentMatching(searchRegExp))
matches.push(record);
}
- this._model.forAllFilteredRecords(processRecord);
+ this._model.forAllFilteredRecords(processRecord.bind(this));
var matchesCount = matches.length;
if (matchesCount) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698