Issue 236683004: DevTools: Merge SearchView into AdvancedSearchController

Issue 236683004: DevTools: Merge SearchView into AdvancedSearchController (Closed)

Created:
6 years, 8 months ago by apavlov

Modified:
6 years, 8 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Merge SearchView into AdvancedSearchController R=pfeldman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171472

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change getter to method #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -625 lines)			Patch
M	LayoutTests/inspector/editor/text-editor-selection-to-search.html	View		1 chunk	+10 lines, -2 lines	0 comments	Download
M	Source/devtools/devtools.gyp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/devtools.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
D	Source/devtools/front_end/AdvancedSearchController.js	View		1 chunk	+0 lines, -476 lines	0 comments	Download
A +	Source/devtools/front_end/AdvancedSearchView.js	View	1	20 chunks	+108 lines, -138 lines	0 comments	Download
M	Source/devtools/front_end/modules.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/scripts/compile_frontend.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/236683004/diff/1/Source/devtools/front_end/AdvancedSearchView.js File Source/devtools/front_end/AdvancedSearchView.js (right): https://chromiumcodereview.appspot.com/236683004/diff/1/Source/devtools/front_end/AdvancedSearchView.js#newcode56 Source/devtools/front_end/AdvancedSearchView.js:56: get searchConfig() Let's make it a method instead.

6 years, 8 months ago (2014-04-14 13:28:56 UTC) #2

apavlov

On 2014/04/14 13:28:56, vsevik wrote: > lgtm > > https://chromiumcodereview.appspot.com/236683004/diff/1/Source/devtools/front_end/AdvancedSearchView.js > File Source/devtools/front_end/AdvancedSearchView.js (right): > ...

6 years, 8 months ago (2014-04-14 14:03:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/236683004/20001

6 years, 8 months ago (2014-04-14 14:03:08 UTC) #5

Message was sent while issue was closed.

Change committed as 171472

Expand Messages | Collapse Messages