Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23668002: Avoid leaking ThreadingPrimitives.h from StackStats.h when collection is off. (Closed)

Created:
7 years, 3 months ago by Chris Evans
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez
Visibility:
Public.

Description

Avoid leaking ThreadingPrimitives.h from StackStats.h when collection is off.

Patch Set 1 #

Patch Set 2 : Just remove StackStats. #

Patch Set 3 : Retry. #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -481 lines) Patch
M Source/core/dom/Document.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderIFrame.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderListItem.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderMedia.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderReplica.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderRubyRun.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbarPart.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderSlider.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTextTrackCue.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderView.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderWidget.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/rendering/svg/RenderSVGForeignObject.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/rendering/svg/RenderSVGGradientStop.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGHiddenContainer.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/wtf/StackStats.h View 1 1 chunk +0 lines, -150 lines 0 comments Download
Source/wtf/StackStats.cpp View 1 1 chunk +0 lines, -286 lines 0 comments Download
M Source/wtf/ThreadingPthreads.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M Source/wtf/WTFThreadData.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Evans
NOTE: I dunno if anyone ever actually turns on the compile-time define of ENABLE_STACK_STATS?? Feel ...
7 years, 3 months ago (2013-08-28 02:46:09 UTC) #1
abarth-chromium
I think you should just rip it out.
7 years, 3 months ago (2013-08-28 03:52:10 UTC) #2
Chris Evans
7 years, 3 months ago (2013-08-28 08:11:22 UTC) #3 
On 2013/08/28 03:52:10, abarth wrote:
> I think you should just rip it out.

Continuing in new issue https://codereview.chromium.org/23521004/ due to App
Engine flake upon upload.
Closing this issue.

Powered by Google App Engine
This is Rietveld 408576698