Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2366773002: [modules] Allow Module::Instantiate to throw exceptions (Closed)

Created:
4 years, 3 months ago by adamk
Modified:
4 years, 3 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Allow Module::Instantiate to throw exceptions Also prepare d8 for that eventuality, and fixup the runtime call stat counter used for Module::Evaluate. R=neis@chromium.org BUG=v8:1569 Committed: https://crrev.com/4453819c9afeaeab720bd3f048a1958f58882921 Cr-Commit-Position: refs/heads/master@{#39647}

Patch Set 1 #

Patch Set 2 : Fix boolean logic and throw an exception for a misbehaving callback #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -20 lines) Patch
M src/api.cc View 1 2 4 chunks +37 lines, -15 lines 0 comments Download
M src/counters.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/d8.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
adamk
4 years, 3 months ago (2016-09-22 21:54:12 UTC) #1
neis
lgtm
4 years, 3 months ago (2016-09-22 22:11:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366773002/40001
4 years, 3 months ago (2016-09-22 22:12:17 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-22 23:06:08 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 23:06:32 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4453819c9afeaeab720bd3f048a1958f58882921
Cr-Commit-Position: refs/heads/master@{#39647}

Powered by Google App Engine
This is Rietveld 408576698