Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2366763002: Milo: Grpc endpoint for multiple builds on a builder (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 2 months ago
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Grpc endpoint for multiple builds on a builder BUG=642461 Committed: https://github.com/luci/luci-go/commit/6d5e649ebb7def4de9ec72e6dc0de5a7acb0146a

Patch Set 1 #

Total comments: 8

Patch Set 2 : Review comments, add smoke test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+526 lines, -264 lines) Patch
M milo/api/proto/buildbot.proto View 1 2 chunks +16 lines, -0 lines 0 comments Download
M milo/api/proto/buildbot.pb.go View 1 8 chunks +105 lines, -22 lines 0 comments Download
M milo/api/proto/buildbotserver_dec.go View 1 chunk +15 lines, -0 lines 0 comments Download
M milo/api/proto/pb.discovery.go View 1 1 chunk +266 lines, -242 lines 0 comments Download
M milo/appengine/buildbot/grpc.go View 1 1 chunk +54 lines, -0 lines 0 comments Download
A milo/appengine/buildbot/grpc_test.go View 1 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
hinoka
just incase someone actually does end up needed this.... not the fastest implementation, but probably ...
4 years, 3 months ago (2016-09-22 21:35:05 UTC) #4
hinoka
ptal Turns out this is needed for test-results
4 years, 2 months ago (2016-10-06 04:40:46 UTC) #8
martiniss
https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grpc.go File milo/appengine/buildbot/grpc.go (right): https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grpc.go#newcode56 milo/appengine/buildbot/grpc.go:56: func (s *Service) GetBuildbotBuildsJSON( Can you add a basic ...
4 years, 2 months ago (2016-10-06 21:18:56 UTC) #9
hinoka
https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grpc.go File milo/appengine/buildbot/grpc.go (right): https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grpc.go#newcode56 milo/appengine/buildbot/grpc.go:56: func (s *Service) GetBuildbotBuildsJSON( On 2016/10/06 21:18:56, martiniss wrote: ...
4 years, 2 months ago (2016-10-07 01:44:54 UTC) #12
martiniss
lgtm
4 years, 2 months ago (2016-10-07 02:18:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366763002/20001
4 years, 2 months ago (2016-10-07 02:24:03 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 02:27:43 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/6d5e649ebb7def4de9ec72e6dc0de5a7acb0146a

Powered by Google App Engine
This is Rietveld 408576698