Milo: Grpc endpoint for multiple builds on a builder

Milo: Grpc endpoint for multiple builds on a builder

BUG=642461
Committed: https://github.com/luci/luci-go/commit/6d5e649ebb7def4de9ec72e6dc0de5a7acb0146a

[Ryan Tseng, 2016-09-22 21:33:59]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 21:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-09-22 21:35:05]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org, martiniss@chromium.org

[hinoka, 2016-09-22 21:35:05]

just incase someone actually does end up needed this....

not the fastest implementation, but probably the one that required the fewest
lines of changes.

[commit-bot: I haz the power, 2016-09-22 22:07:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 22:07:46]

Dry run: This issue passed the CQ dry run.

[hinoka, 2016-10-06 04:40:46]

hinoka@chromium.org changed reviewers:
+ estaab@chromium.org, zhangtiff@chromium.org

[hinoka, 2016-10-06 04:40:46]

ptal

Turns out this is needed for test-results

[martiniss, 2016-10-06 21:18:56]

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
File milo/appengine/buildbot/grpc.go (right):

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
milo/appengine/buildbot/grpc.go:56: func (s *Service) GetBuildbotBuildsJSON(
Can you add a basic smoke test or two for this?

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
milo/appengine/buildbot/grpc.go:78: limit = 50
buildbot default limit is 20, why not replicate that?

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
milo/appengine/buildbot/grpc.go:84: Eq("finished", true).
Do we want to always require finished? Can we make that a parameter?

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
milo/appengine/buildbot/grpc.go:104: Builds: results,
Is this going to run into app engine response size constraints like the buildbot
master JSON did?

[Ryan Tseng, 2016-10-07 01:39:05]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 01:39:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-10-07 01:44:54]

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
File milo/appengine/buildbot/grpc.go (right):

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
milo/appengine/buildbot/grpc.go:56: func (s *Service) GetBuildbotBuildsJSON(
On 2016/10/06 21:18:56, martiniss wrote:
> Can you add a basic smoke test or two for this?

Done.

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
milo/appengine/buildbot/grpc.go:78: limit = 50
On 2016/10/06 21:18:56, martiniss wrote:
> buildbot default limit is 20, why not replicate that?

test-results used 50 i think.  Both are equally arbitrary for me.  20 would be
less strain tho.

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
milo/appengine/buildbot/grpc.go:84: Eq("finished", true).
On 2016/10/06 21:18:56, martiniss wrote:
> Do we want to always require finished? Can we make that a parameter?

Done.

https://codereview.chromium.org/2366763002/diff/1/milo/appengine/buildbot/grp...
milo/appengine/buildbot/grpc.go:104: Builds: results,
On 2016/10/06 21:18:56, martiniss wrote:
> Is this going to run into app engine response size constraints like the
buildbot
> master JSON did?

Unlikely I think.  The main issue we run into usually is the 1MB datastore
limit.  The appengine response limit is 32MB, so theres much more leeway.  Still
possible with a large response size, but CBE has been happily serving responses
of about 50 builds for a while, so I think we're safe.

[commit-bot: I haz the power, 2016-10-07 01:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 01:47:24]

Dry run: This issue passed the CQ dry run.

[martiniss, 2016-10-07 02:18:46]

lgtm

[hinoka, 2016-10-07 02:23:58]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-10-07 02:24:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 02:27:42]

Description was changed from

==========
Milo: Grpc endpoint for multiple builds on a builder

BUG=642461
==========

to

==========
Milo: Grpc endpoint for multiple builds on a builder

BUG=642461

Committed:
https://github.com/luci/luci-go/commit/6d5e649ebb7def4de9ec72e6dc0de5a7acb0146a
==========

[commit-bot: I haz the power, 2016-10-07 02:27:43]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/6d5e649ebb7def4de9ec72e6dc0de5a7acb0146a