Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2366753004: input[type=range]: Updating step attribute should align the value to steps. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

input[type=range]: Updating step attribute should align the value to steps. BUG=633074 Committed: https://crrev.com/14d43b4c79aeb380ef35fa9167ccd955fd1d32d1 Cr-Commit-Position: refs/heads/master@{#420798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/range/ValidityState-stepMismatch-range.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/range/ValidityState-stepMismatch-range-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Keishi, would you review this please?
4 years, 3 months ago (2016-09-23 07:15:23 UTC) #4
keishi
LGTM
4 years, 3 months ago (2016-09-23 18:47:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366753004/1
4 years, 3 months ago (2016-09-23 22:42:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-24 00:17:42 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-24 00:19:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14d43b4c79aeb380ef35fa9167ccd955fd1d32d1
Cr-Commit-Position: refs/heads/master@{#420798}

Powered by Google App Engine
This is Rietveld 408576698