[WebCrypto] Use ScriptPromiseResolverWithContext.

Source/modules/crypto/CryptoResultImpl.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "modules/crypto/CryptoResultImpl.h"
 
-#include "bindings/v8/ScriptPromiseResolver.h"
+#include "bindings/v8/NewScriptState.h"
+#include "bindings/v8/ScriptPromiseResolverWithContext.h"
 #include "core/dom/ExecutionContext.h"
 #include "modules/crypto/Key.h"
 #include "modules/crypto/KeyPair.h"
 #include "modules/crypto/NormalizeAlgorithm.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebArrayBuffer.h"
 #include "public/platform/WebCryptoAlgorithm.h"
 #include "wtf/ArrayBufferView.h"
 
 namespace WebCore {
 
 CryptoResultImpl::~CryptoResultImpl()
 {
 }
 
 PassRefPtr<CryptoResultImpl> CryptoResultImpl::create()
 {
     return adoptRef(new CryptoResultImpl(callingExecutionContext(v8::Isolate::GetCurrent())));
 }
 
 void CryptoResultImpl::completeWithError(const blink::WebString& errorDetails)
 {
     ASSERT(!m_finished);
 
     if (canCompletePromise()) {
-        NewScriptState::Scope scope(m_scriptState.get());

[eroman, 2014/04/16 17:35:05]

Does the call to:

   execuctionContext()->addConsoleMessage() below require the script context to
be active?

[yhirano, 2014/04/17 01:51:25]

AFAIK addConsoleMessage doesn't require to be in a V8 context.

[yurys, 2014/04/17 09:27:13]

Correct, addConsoleMessage doesn't require V8 to be in a context as the messages
may well be added from native code that doesn't enter v8 at all. 

         if (!errorDetails.isEmpty()) {
             // FIXME: Include the line number which started the crypto operation.
             executionContext()->addConsoleMessage(JSMessageSource, ErrorMessageLevel, errorDetails);
         }
-        m_promiseResolver->reject(ScriptValue::createNull());
+        m_promiseResolver->reject(ScriptPromiseResolverWithContext::null());
     }
 }
 
 void CryptoResultImpl::completeWithError()
 {
     completeWithError(blink::WebString());
 }
 
 void CryptoResultImpl::completeWithBuffer(const blink::WebArrayBuffer& buffer)
 {
     ASSERT(!m_finished);
 
     if (canCompletePromise()) {
-        NewScriptState::Scope scope(m_scriptState.get());
         m_promiseResolver->resolve(PassRefPtr<ArrayBuffer>(buffer));
     }
 
     finish();
 }
 
 void CryptoResultImpl::completeWithBoolean(bool b)
 {
     ASSERT(!m_finished);
 
     if (canCompletePromise()) {
-        NewScriptState::Scope scope(m_scriptState.get());
-        m_promiseResolver->resolve(ScriptValue::createBoolean(b));
+        m_promiseResolver->resolve(ScriptPromiseResolverWithContext::Boolean(b));
     }
 
     finish();
 }
 
 void CryptoResultImpl::completeWithKey(const blink::WebCryptoKey& key)
 {
     ASSERT(!m_finished);
 
     if (canCompletePromise()) {
-        NewScriptState::Scope scope(m_scriptState.get());
         m_promiseResolver->resolve(Key::create(key));

[eroman, 2014/04/16 17:35:05]

If we remove canCompletePromise(), would it be safe to call things like
Key::create()? (Apologies, not quite sure how ScriptWrappable works).

[yhirano, 2014/04/17 01:51:25]

The ScriptWrappable constructor and ScriptWrappable::init can work without a V8
context.

     }
 
     finish();
 }
 
 void CryptoResultImpl::completeWithKeyPair(const blink::WebCryptoKey& publicKey, const blink::WebCryptoKey& privateKey)
 {
     ASSERT(!m_finished);
 
     if (canCompletePromise()) {
-        NewScriptState::Scope scope(m_scriptState.get());
         m_promiseResolver->resolve(KeyPair::create(publicKey, privateKey));
     }
 
     finish();
 }
 
 CryptoResultImpl::CryptoResultImpl(ExecutionContext* context)
     : ContextLifecycleObserver(context)
-    , m_promiseResolver(ScriptPromiseResolver::create(context))
-    , m_scriptState(NewScriptState::current(toIsolate(context)))
+    , m_promiseResolver(ScriptPromiseResolverWithContext::create(NewScriptState::current(toIsolate(context))))
 #if !ASSERT_DISABLED
     , m_owningThread(currentThread())
     , m_finished(false)
 #endif
 {
 }
 
 void CryptoResultImpl::finish()
 {
 #if !ASSERT_DISABLED
     m_finished = true;
 #endif
     clearPromiseResolver();
 }
 
 void CryptoResultImpl::clearPromiseResolver()
 {
     m_promiseResolver.clear();
-    m_scriptState.clear();
 }
 
 void CryptoResultImpl::CheckValidThread() const
 {
     ASSERT(m_owningThread == currentThread());
 }
 
 void CryptoResultImpl::contextDestroyed()

[eroman, 2014/04/16 17:35:05]

Can this be removed?

[yhirano, 2014/04/17 01:51:25]

Basically, yes. But I think it is better to do that in a separate CL because
canCompletePromise() requires a ContextLifeCycle's method.
The change will get much easier after https://codereview.chromium.org/236713003/
is landed.

 {
     ContextLifecycleObserver::contextDestroyed();
 
     // Abandon the promise without completing it when the context goes away.
     clearPromiseResolver();
     ASSERT(!canCompletePromise());
 }
 
 bool CryptoResultImpl::canCompletePromise() const

[eroman, 2014/04/16 17:35:05]

Can this be removed now since handled internally by promiseresolver?

[yhirano, 2014/04/17 01:51:25]

Basically, yes. But you use this function to decide decide whether to call
addConsoleMessage. Therefore I think it is better to tidy at another CL.

 {
     CheckValidThread();
     ExecutionContext* context = executionContext();
     return context && !context->activeDOMObjectsAreSuspended() && !context->activeDOMObjectsAreStopped();
 }
 
 } // namespace WebCore