Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 2366723004: Revert of Create special surfaces according to original device (not always in N32) (Closed)

Created:
4 years, 2 months ago by Brian Osman
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Create special surfaces according to original device (not always in N32) (patchset #9 id:160001 of https://codereview.chromium.org/2349373004/ ) Reason for revert: DM crash and/or TSAN failure Original issue's description: > Change SkSpecialImage::makeSurface and makeTightSurface to take output > properties (color space), bounds, and (optional) alphaType. > > We were being pretty inconsistent before. Raster was honoring all > components of the info. GPU was using the supplied color type, but > propagating the source's color space. All call sites were saying N32. > > What we want to do is propagate the original device's color space, and > pick a good format from that. Rather than force all the clients to > jump through hoops constructing an SkImageInfo that meets our criteria, > just have them supply the few bits we care about, and do everything else > internally. > > This also lets us always use RGBA on GPU, but N32 on raster. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2349373004 > > Committed: https://skia.googlesource.com/skia/+/53c38087949252d27cde668368a3eeb59cc2eb00 TBR=robertphillips@google.com,reed@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a76554d2ae7f676776c1d472aa433b048f418ea9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -94 lines) Patch
M src/core/SkImageFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkMatrixImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkSpecialImage.h View 2 chunks +3 lines, -8 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 6 chunks +17 lines, -52 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -12 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkImageSource.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/effects/SkOffsetImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkPaintImageFilter.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 3 chunks +9 lines, -3 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tests/SpecialImageTest.cpp View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Osman
Created Revert of Create special surfaces according to original device (not always in N32)
4 years, 2 months ago (2016-09-23 15:49:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366723004/1
4 years, 2 months ago (2016-09-23 15:49:42 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 15:49:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a76554d2ae7f676776c1d472aa433b048f418ea9

Powered by Google App Engine
This is Rietveld 408576698