|
|
DescriptionUpdate "Learn more" link in accessibility detailed view
"Learn more" link in accessibility detailed view is used to point to the
how to turn on accessibility features page, it is now updated to point to
the general help page of accessibility.
BUG=638439
Committed: https://crrev.com/1a5da60f9cfe8bcf47055a8a7b6588a864a849cd
Cr-Commit-Position: refs/heads/master@{#420733}
Patch Set 1 #
Total comments: 4
Patch Set 2 : update link #Messages
Total messages: 24 (13 generated)
Description was changed from ========== update the learn more link in accessibility BUG=638439 ========== to ========== Update "Learn more" link in accessibility detailed view Updates the "Learn more" in accessibility detailed view to point to the general accessibility page. BUG=638439 ==========
The CQ bit was checked by yiyix@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Update "Learn more" link in accessibility detailed view Updates the "Learn more" in accessibility detailed view to point to the general accessibility page. BUG=638439 ========== to ========== Update "Learn more" link in accessibility detailed view Updates the "Learn more" link in accessibility detailed view to point to the general accessibility help page. BUG=638439 ==========
Description was changed from ========== Update "Learn more" link in accessibility detailed view Updates the "Learn more" link in accessibility detailed view to point to the general accessibility help page. BUG=638439 ========== to ========== Update "Learn more" link in accessibility detailed view "Learn more" link in accessibility detailed view is used to point to the how to turn on accessibility features page, it is now updated to point to the general help page of accessibility. BUG=638439 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
yiyix@chromium.org changed reviewers: + sky@chromium.org
@sky, Could you please take a look at this code change?
sky@chromium.org changed reviewers: + dmazzoni@chromium.org
I have no idea if this is right. +dmazzoni https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc File chrome/common/url_constants.cc (right): https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants... chrome/common/url_constants.cc:435: "6323347?hl=en&ref_topic=3399710"; Does that second parameter mean everyone gets english results?
yiyix@chromium.org changed reviewers: + tdanderson@chromium.org
https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc File chrome/common/url_constants.cc (right): https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants... chrome/common/url_constants.cc:435: "6323347?hl=en&ref_topic=3399710"; On 2016/09/23 17:25:56, sky wrote: > Does that second parameter mean everyone gets english results? Users can change languages on the page, you can play with the link. https://support.google.com/chromebook/topic/6323347?hl=en&ref_topic=3399710
What does the hl=en do there? Is it really needed? On Fri, Sep 23, 2016 at 10:48 AM, <yiyix@chromium.org> wrote: > > https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc > File chrome/common/url_constants.cc (right): > > https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants... > chrome/common/url_constants.cc:435: "6323347?hl=en&ref_topic=3399710"; > On 2016/09/23 17:25:56, sky wrote: >> Does that second parameter mean everyone gets english results? > > Users can change languages on the page, you can play with the link. > https://support.google.com/chromebook/topic/6323347?hl=en&ref_topic=3399710 > > https://codereview.chromium.org/2366713003/ -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc File chrome/common/url_constants.cc (right): https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants... chrome/common/url_constants.cc:435: "6323347?hl=en&ref_topic=3399710"; You should just use this url, it will automatically redirect to the user's preferred language: https://support.google.com/chromebook/topic/6323347
Thank you for the suggestion @dmazzoni! I tried to set my preferred language to other language and the page is shown in that language. https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc File chrome/common/url_constants.cc (right): https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants... chrome/common/url_constants.cc:435: "6323347?hl=en&ref_topic=3399710"; On 2016/09/23 18:14:03, dmazzoni wrote: > You should just use this url, it will automatically redirect to the > user's preferred language: > > https://support.google.com/chromebook/topic/6323347 I think this link is better. I will update both the bug description and this cl. Thank you.
lgtm
The CQ bit was checked by yiyix@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
Message was sent while issue was closed.
Description was changed from ========== Update "Learn more" link in accessibility detailed view "Learn more" link in accessibility detailed view is used to point to the how to turn on accessibility features page, it is now updated to point to the general help page of accessibility. BUG=638439 ========== to ========== Update "Learn more" link in accessibility detailed view "Learn more" link in accessibility detailed view is used to point to the how to turn on accessibility features page, it is now updated to point to the general help page of accessibility. BUG=638439 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update "Learn more" link in accessibility detailed view "Learn more" link in accessibility detailed view is used to point to the how to turn on accessibility features page, it is now updated to point to the general help page of accessibility. BUG=638439 ========== to ========== Update "Learn more" link in accessibility detailed view "Learn more" link in accessibility detailed view is used to point to the how to turn on accessibility features page, it is now updated to point to the general help page of accessibility. BUG=638439 Committed: https://crrev.com/1a5da60f9cfe8bcf47055a8a7b6588a864a849cd Cr-Commit-Position: refs/heads/master@{#420733} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1a5da60f9cfe8bcf47055a8a7b6588a864a849cd Cr-Commit-Position: refs/heads/master@{#420733} |