Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2366713003: Update "Learn more" link in accessibility detailed view (Closed)

Created:
4 years, 2 months ago by yiyix
Modified:
4 years, 2 months ago
Reviewers:
tdanderson, dmazzoni, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update "Learn more" link in accessibility detailed view "Learn more" link in accessibility detailed view is used to point to the how to turn on accessibility features page, it is now updated to point to the general help page of accessibility. BUG=638439 Committed: https://crrev.com/1a5da60f9cfe8bcf47055a8a7b6588a864a849cd Cr-Commit-Position: refs/heads/master@{#420733}

Patch Set 1 #

Total comments: 4

Patch Set 2 : update link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/url_constants.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (13 generated)
yiyix
@sky, Could you please take a look at this code change?
4 years, 2 months ago (2016-09-23 00:21:09 UTC) #9
sky
I have no idea if this is right. +dmazzoni https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc File chrome/common/url_constants.cc (right): https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc#newcode435 chrome/common/url_constants.cc:435: ...
4 years, 2 months ago (2016-09-23 17:25:56 UTC) #11
yiyix
https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc File chrome/common/url_constants.cc (right): https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc#newcode435 chrome/common/url_constants.cc:435: "6323347?hl=en&ref_topic=3399710"; On 2016/09/23 17:25:56, sky wrote: > Does that ...
4 years, 2 months ago (2016-09-23 17:48:04 UTC) #13
sky
What does the hl=en do there? Is it really needed? On Fri, Sep 23, 2016 ...
4 years, 2 months ago (2016-09-23 18:09:47 UTC) #14
dmazzoni
https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc File chrome/common/url_constants.cc (right): https://codereview.chromium.org/2366713003/diff/1/chrome/common/url_constants.cc#newcode435 chrome/common/url_constants.cc:435: "6323347?hl=en&ref_topic=3399710"; You should just use this url, it will ...
4 years, 2 months ago (2016-09-23 18:14:04 UTC) #15
yiyix
Thank you for the suggestion @dmazzoni! I tried to set my preferred language to other ...
4 years, 2 months ago (2016-09-23 19:34:22 UTC) #16
dmazzoni
lgtm
4 years, 2 months ago (2016-09-23 19:39:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366713003/20001
4 years, 2 months ago (2016-09-23 20:04:17 UTC) #19
sky
LGTM
4 years, 2 months ago (2016-09-23 20:11:29 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-23 21:27:04 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 21:29:21 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a5da60f9cfe8bcf47055a8a7b6588a864a849cd
Cr-Commit-Position: refs/heads/master@{#420733}

Powered by Google App Engine
This is Rietveld 408576698