content/test/data/navigation_controller/beforeunload_dialog.html - Issue 2366693006: Don't show dialogs from swapped out frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/navigation_controller/beforeunload_dialog.html

Issue 2366693006: Don't show dialogs from swapped out frames. (Closed)

Patch Set: now thread safe Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/data/navigation_controller/beforeunload_dialog.html

diff --git a/content/test/data/navigation_controller/beforeunload_replacestate_2.html b/content/test/data/navigation_controller/beforeunload_dialog.html

similarity index 62%

copy from content/test/data/navigation_controller/beforeunload_replacestate_2.html

copy to content/test/data/navigation_controller/beforeunload_dialog.html

index 0a65d257d3df1119ef641a1daeb5f3c5e2712e48..8e3c825e629fa5f5d2a62ed14fb1aad72c51bf73 100644

--- a/content/test/data/navigation_controller/beforeunload_replacestate_2.html

+++ b/content/test/data/navigation_controller/beforeunload_dialog.html

@@ -2,7 +2,9 @@

<head>

window.addEventListener("beforeunload", function (event) {

- window.history.replaceState(null, "", "beforeunload_replacestate_2.html");

+ setTimeout(function() {

+ window.alert("hi");

+ }, 0);

});

</script>

</head>

« content/browser/frame_host/navigation_controller_impl_browsertest.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | no next file » | no next file with comments »