Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2366693004: Adds debugging accelerator to toggle Wi-Fi on Chrome OS (Closed)

Created:
4 years, 3 months ago by varkha
Modified:
4 years, 3 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds debugging accelerator to toggle Wi-Fi on Chrome OS Adds Alt+Ctrl+Shift+N to toggle Wi-Fi on or off when running with --ash-debug-shortcuts. BUG=NONE Committed: https://crrev.com/f48d3b6d19cec0b58e742ed9de12d3db7529d60f Cr-Commit-Position: refs/heads/master@{#420548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ash/common/accelerators/accelerator_table.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
varkha
jamescook@, this was useful to me when working on network view in system menu. Do ...
4 years, 3 months ago (2016-09-22 23:55:27 UTC) #2
James Cook
LGTM. I like debugging shortcuts.
4 years, 3 months ago (2016-09-23 01:16:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366693004/1
4 years, 3 months ago (2016-09-23 02:20:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 02:25:07 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 02:26:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f48d3b6d19cec0b58e742ed9de12d3db7529d60f
Cr-Commit-Position: refs/heads/master@{#420548}

Powered by Google App Engine
This is Rietveld 408576698