Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2366693003: Do not reference non-existant bundled flash on Chrome OS. (Closed)

Created:
4 years, 3 months ago by Greg K
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Do not reference non-existant bundled flash on Chrome OS. Chrome on Chrome OS is incorrectly building against the Flash player bundled in third_party/. However, on Chrome OS, flash player is loaded from the root partition and passed to Chrome via command line. So Chrome should not be referencing the versions in flapper_version.h. In addition, this means the bundled flash player loading code is unused. BUG=644795, 644400 Review-Url: https://codereview.chromium.org/2340643002 Cr-Commit-Position: refs/heads/master@{#419513} (cherry picked from commit cf804457306e0facdb59124fa38b5315493e1da7) Committed: https://chromium.googlesource.com/chromium/src/+/00777c52ac61dba4cd3d9047ede488f337d4a9a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -38 lines) Patch
M chrome/common/chrome_content_client.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M third_party/adobe/flash/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Greg K
4 years, 3 months ago (2016-09-22 22:43:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00777c52ac61dba4cd3d9047ede488f337d4a9a5.

Powered by Google App Engine
This is Rietveld 408576698