Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2366673003: Rename CPDF_CountedObject to CFX_WeakPtr::Handle (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename CPDF_CountedObject to CFX_WeakPtr::Handle This better describes its purpose, and reduces confusion with the CFX_CountRef class, which is unrelated. The WeakPtr class itself that manipulates handles is NYI. Committed: https://pdfium.googlesource.com/pdfium/+/fe0179ded8202939ea4f2b92a879b8dede7821ea

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -66 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_countedobject.h View 1 chunk +0 lines, -47 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pattern.h View 2 chunks +3 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingpattern.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_colorspace.h View 2 chunks +3 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 3 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_render/render_int.h View 2 chunks +3 lines, -3 lines 0 comments Download
A core/fxcrt/include/cfx_weak_ptr.h View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
Dan, for review. Small step in making this saner.
4 years, 3 months ago (2016-09-22 20:16:01 UTC) #2
dsinclair
lgtm
4 years, 3 months ago (2016-09-22 20:24:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366673003/20001
4 years, 3 months ago (2016-09-22 20:24:53 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 20:42:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/fe0179ded8202939ea4f2b92a879b8dede78...

Powered by Google App Engine
This is Rietveld 408576698