Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2366673002: Updating benchmark script to only write chartjson when flag present. (Closed)

Created:
4 years, 3 months ago by eyaich1
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating benchmark script to only write chartjson when flag present. BUG=chromium:633253 Committed: https://crrev.com/da48d3aacdbb1154a42e15aaa5d37c3e1725ea9c Cr-Commit-Position: refs/heads/master@{#420675}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Lazily creating charjson output file #

Patch Set 3 : Using argparse api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M testing/scripts/run_telemetry_benchmark_as_googletest.py View 1 2 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
eyaich1
4 years, 3 months ago (2016-09-22 18:00:55 UTC) #2
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/2366673002/diff/1/testing/scripts/run_telemetry_benchmark_as_googletest.py File testing/scripts/run_telemetry_benchmark_as_googletest.py (right): https://codereview.chromium.org/2366673002/diff/1/testing/scripts/run_telemetry_benchmark_as_googletest.py#newcode58 testing/scripts/run_telemetry_benchmark_as_googletest.py:58: break Instead of this somewhat contorted code, could you ...
4 years, 3 months ago (2016-09-22 20:31:48 UTC) #3
eyaich1
https://codereview.chromium.org/2366673002/diff/1/testing/scripts/run_telemetry_benchmark_as_googletest.py File testing/scripts/run_telemetry_benchmark_as_googletest.py (right): https://codereview.chromium.org/2366673002/diff/1/testing/scripts/run_telemetry_benchmark_as_googletest.py#newcode58 testing/scripts/run_telemetry_benchmark_as_googletest.py:58: break On 2016/09/22 20:31:48, Ken Russell wrote: > Instead ...
4 years, 3 months ago (2016-09-23 13:52:38 UTC) #4
Ken Russell (switch to Gerrit)
Yay. :) LGTM
4 years, 3 months ago (2016-09-23 17:29:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366673002/40001
4 years, 3 months ago (2016-09-23 17:31:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 18:43:22 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 18:47:23 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/da48d3aacdbb1154a42e15aaa5d37c3e1725ea9c
Cr-Commit-Position: refs/heads/master@{#420675}

Powered by Google App Engine
This is Rietveld 408576698