Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2366643002: Add ThreadChecker for Ozone X11 GPU. (Closed)

Created:
4 years, 2 months ago by kylechar
Modified:
4 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ThreadChecker for Ozone X11 GPU. Ensure Ozone X11 tests the same thread constraints we have in Ozone GBM. BUG=none Committed: https://crrev.com/0d77de2f5334b6d560487c5fd696178a3bfc3551 Cr-Commit-Position: refs/heads/master@{#421817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/ozone/platform/x11/x11_surface_factory.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kylechar
4 years, 2 months ago (2016-09-22 18:23:02 UTC) #2
kylechar
Will land after you've got your fix in for the GPU thread stuff.
4 years, 2 months ago (2016-09-22 18:23:26 UTC) #3
sadrul
lgtm
4 years, 2 months ago (2016-09-23 23:23:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366643002/1
4 years, 2 months ago (2016-09-29 14:32:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 14:52:25 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0d77de2f5334b6d560487c5fd696178a3bfc3551 Cr-Commit-Position: refs/heads/master@{#421817}
4 years, 2 months ago (2016-09-29 14:54:56 UTC) #9
kylechar
4 years, 2 months ago (2016-10-11 18:02:51 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2409263002/ by kylechar@chromium.org.

The reason for reverting is: Breaks multiple unit tests under Ozone X11..

Powered by Google App Engine
This is Rietveld 408576698