[DevTools] Focus sidebar trees in certain panels by default.

third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 /**
  * @constructor
  * @extends {WebInspector.PanelWithSidebar}
  */
 WebInspector.AuditsPanel = function()
 {
     WebInspector.PanelWithSidebar.call(this, "audits");
     this.registerRequiredCSS("ui/panelEnablerView.css");
     this.registerRequiredCSS("audits/auditsPanel.css");
 
-    var sidebarTree = new TreeOutlineInShadow();
-    sidebarTree.registerRequiredCSS("audits/auditsSidebarTree.css");
-    this.panelSidebarElement().appendChild(sidebarTree.element);
-    this.setDefaultFocusedElement(sidebarTree.element);
+    this._sidebarTree = new TreeOutlineInShadow();
+    this._sidebarTree.registerRequiredCSS("audits/auditsSidebarTree.css");
+    this.panelSidebarElement().appendChild(this._sidebarTree.element);
 
     this._auditsItemTreeElement = new WebInspector.AuditsSidebarTreeElement(this);
-    sidebarTree.appendChild(this._auditsItemTreeElement);
+    this._sidebarTree.appendChild(this._auditsItemTreeElement);
 
     this._auditResultsTreeElement = new TreeElement(WebInspector.UIString("RESULTS"), true);
     this._auditResultsTreeElement.selectable = false;
     this._auditResultsTreeElement.listItemElement.classList.add("audits-sidebar-results");
     this._auditResultsTreeElement.expand();
-    sidebarTree.appendChild(this._auditResultsTreeElement);
+    this._sidebarTree.appendChild(this._auditResultsTreeElement);
 
     this._constructCategories();
 
     this._auditController = new WebInspector.AuditController(this);
     this._launcherView = new WebInspector.AuditLauncherView(this._auditController);
     for (var id in this.categoriesById)
         this._launcherView.addCategory(this.categoriesById[id]);
 
     var extensionCategories = WebInspector.extensionServer.auditCategories();
     for (var i = 0; i < extensionCategories.length; ++i) {
@@ skipping 97 matching lines @@
             this.splitWidget().setMainWidget(x);
     },
 
     wasShown: function()
     {
         WebInspector.Panel.prototype.wasShown.call(this);
         if (!this._visibleView)
             this._auditsItemTreeElement.select();
     },
 
+    /**
+     * @override
+     */
+    focus: function()
+    {
+        this._sidebarTree.focus();

[einbinder, 2016/09/22 22:48:24]

Why not this.setDefaultFocusedChild(this.splitWidget().sidebarWidget()) and
this.splitWidget().sidebarWidget().setDefaultFocusedChild(sidebarTree) instead? 

[dgozman, 2016/09/23 00:43:09]

I see two problems in that:
- we call setDefaultFocusedChild on other widget (ideally I'd make it
"protected");
- we have to access sidebarTree.contentElement (which I'd make "protected" as
well).

+    },
+
     clearResults: function()
     {
         this._auditsItemTreeElement.revealAndSelect();
         this._auditResultsTreeElement.removeChildren();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _extensionAuditCategoryAdded: function(event)
@@ skipping 356 matching lines @@
 }
 
 // Contributed audit rules should go into this namespace.
 WebInspector.AuditRules = {};
 
 /**
  * Contributed audit categories should go into this namespace.
  * @type {!Object.<string, function(new:WebInspector.AuditCategory)>}
  */
 WebInspector.AuditCategories = {};