[Android] emma_instr.py now removes any stale *.em/*sources.txt

build/android/generate_emma_html.py

 #!/usr/bin/env python
 
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Aggregates EMMA coverage files to produce html output."""
 
 import fnmatch
 import json
@@ skipping 38 matching lines @@
                            help='If set, removes coverage/metadata files.')
   options, args = option_parser.parse_args()
 
   if not (options.coverage_dir and options.metadata_dir and options.output):
     option_parser.error('One or more mandatory options are missing.')
 
   coverage_files = _GetFilesWithExt(options.coverage_dir, 'ec')
   metadata_files = _GetFilesWithExt(options.metadata_dir, 'em')
   print 'Found coverage files: %s' % str(coverage_files)
   print 'Found metadata files: %s' % str(metadata_files)
-  sources_files = []
-  final_metadata_files = []
-  err = None
+
+  sources = []
   for f in metadata_files:
     sources_file = os.path.splitext(f)[0] + '_sources.txt'
-    # TODO(gkanwar): Remove this once old coverage.em files have been cleaned
-    # from all bots.
-    # Warn if we have old metadata files lying around that don't correspond
-    # to a *_sources.txt (these should be manually cleaned).
-    try:
-      with open(sources_file, 'r') as sf:
-        sources_files.extend(json.load(sf))
-    except IOError as e:
-      traceback.print_exc()
-      err = e
-    else:
-      final_metadata_files.append(f)
-  sources_files = [os.path.join(constants.DIR_SOURCE_ROOT, s)
-                   for s in sources_files]
+    with open(sources_file, 'r') as sf:
+      sources.extend(json.load(sf))
+  sources = [os.path.join(constants.DIR_SOURCE_ROOT, s) for s in sources]
+  print 'Sources: %s' % sources

[cjhopman, 2013/08/30 17:59:40]

Note: this print is new. Just confirming that's intentional.

[frankf, 2013/08/30 18:12:36]

Yea, they've been helpful in debugging.

 
   input_args = []
-  for f in coverage_files + final_metadata_files:
+  for f in coverage_files + metadata_files:
     input_args.append('-in')
     input_args.append(f)
 
   output_args = ['-Dreport.html.out.file', options.output]
-  source_args = ['-sp', ','.join(sources_files)]
+  source_args = ['-sp', ','.join(sources)]
 
   exit_code = cmd_helper.RunCmd(
       ['java', '-cp',
        os.path.join(constants.ANDROID_SDK_ROOT, 'tools', 'lib', 'emma.jar'),
        'emma', 'report', '-r', 'html']
       + input_args + output_args + source_args)
 
   if options.cleanup:
-    for f in coverage_files + metadata_files:
+    for f in coverage_files:
       os.remove(f)
 
-  if exit_code > 0:
-    return exit_code
-  elif err:
-    return constants.WARNING_EXIT_CODE
-  else:
-    return 0
+  return exit_code
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))