Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2366573002: [parser] Use Back2() where appropriate. (Closed)

Created:
4 years, 3 months ago by vogelheim
Modified:
4 years, 3 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Use Back2() where appropriate. R=marja@chromium.org BUG=v8:4947 Committed: https://crrev.com/295bafd4bce8e4904ae191e14f492dea2b88e500 Cr-Commit-Position: refs/heads/master@{#39662}

Patch Set 1 #

Patch Set 2 : Add comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -31 lines) Patch
M src/parsing/scanner.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/parsing/scanner.cc View 3 chunks +31 lines, -29 lines 0 comments Download
M test/cctest/parsing/test-scanner.cc View 2 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
vogelheim
ptal
4 years, 3 months ago (2016-09-22 13:35:50 UTC) #3
marja
lgtm
4 years, 3 months ago (2016-09-23 07:39:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366573002/20001
4 years, 3 months ago (2016-09-23 11:07:22 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-23 13:07:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366573002/20001
4 years, 3 months ago (2016-09-23 13:08:21 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 13:16:05 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 13:16:30 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/295bafd4bce8e4904ae191e14f492dea2b88e500
Cr-Commit-Position: refs/heads/master@{#39662}

Powered by Google App Engine
This is Rietveld 408576698