Source/core/dom/MutationRecord.h - Issue 236653002: Oilpan: move mutation observers to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/MutationRecord.h

Issue 236653002: Oilpan: move mutation observers to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have MutationObserver keep weak references to its registrations Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/MutationObserverRegistration.cpp ('K') | « Source/core/dom/MutationObserverRegistration.cpp ('k') | Source/core/dom/MutationRecord.cpp » ('j') | Source/core/dom/Node.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/MutationRecord.h

diff --git a/Source/core/dom/MutationRecord.h b/Source/core/dom/MutationRecord.h

index 2c9812e0e05d2dff58f30f61b45ff701ae874f8f..d4293198ebe4a92a22804e3bf3e7f4f5d57b02b4 100644

--- a/Source/core/dom/MutationRecord.h

+++ b/Source/core/dom/MutationRecord.h

@@ -32,6 +32,7 @@

#define MutationRecord_h

#include "bindings/v8/ScriptWrappable.h"

+#include "platform/heap/Handle.h"

#include "wtf/PassRefPtr.h"

#include "wtf/RefCounted.h"

#include "wtf/text/WTFString.h"

@@ -42,12 +43,12 @@ class Node;

class NodeList;

class QualifiedName;

-class MutationRecord : public RefCounted<MutationRecord>, public ScriptWrappable {

+class MutationRecord : public RefCountedWillBeGarbageCollectedFinalized<MutationRecord>, public ScriptWrappable {

public:

- static PassRefPtr<MutationRecord> createChildList(PassRefPtr<Node> target, PassRefPtr<NodeList> added, PassRefPtr<NodeList> removed, PassRefPtr<Node> previousSibling, PassRefPtr<Node> nextSibling);

- static PassRefPtr<MutationRecord> createAttributes(PassRefPtr<Node> target, const QualifiedName&, const AtomicString& oldValue);

- static PassRefPtr<MutationRecord> createCharacterData(PassRefPtr<Node> target, const String& oldValue);

- static PassRefPtr<MutationRecord> createWithNullOldValue(PassRefPtr<MutationRecord>);

+ static PassRefPtrWillBeRawPtr<MutationRecord> createChildList(PassRefPtr<Node> target, PassRefPtr<NodeList> added, PassRefPtr<NodeList> removed, PassRefPtr<Node> previousSibling, PassRefPtr<Node> nextSibling);

+ static PassRefPtrWillBeRawPtr<MutationRecord> createAttributes(PassRefPtr<Node> target, const QualifiedName&, const AtomicString& oldValue);

+ static PassRefPtrWillBeRawPtr<MutationRecord> createCharacterData(PassRefPtr<Node> target, const String& oldValue);

+ static PassRefPtrWillBeRawPtr<MutationRecord> createWithNullOldValue(PassRefPtrWillBeRawPtr<MutationRecord>);

MutationRecord()

{

@@ -68,6 +69,9 @@ public:

virtual const AtomicString& attributeNamespace() { return nullAtom; }

virtual String oldValue() { return String(); }

+ virtual void trace(Visitor*) { }

};

} // namespace WebCore

« Source/core/dom/MutationObserverRegistration.cpp ('K') | « Source/core/dom/MutationObserverRegistration.cpp ('k') | Source/core/dom/MutationRecord.cpp » ('j') | Source/core/dom/Node.cpp » ('J')