Oilpan: move mutation observers to the Oilpan heap.

Source/core/dom/NodeRareData.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/dom/NodeRareData.h"
 #include "core/dom/Element.h"
+#include "platform/heap/Handle.h"
 
 namespace WebCore {
 
 struct SameSizeAsNodeRareData {
-    void* m_pointer[3];
+    void* m_pointer[2];
+    OwnPtrWillBePersistent<NodeMutationObserverData> m_mutationObserverData;
     unsigned m_bitfields;
 };
 
 COMPILE_ASSERT(sizeof(NodeRareData) == sizeof(SameSizeAsNodeRareData), NodeRareDataShouldStaySmall);
 
 void NodeListsNodeData::invalidateCaches(const QualifiedName* attrName)
 {
     NodeListAtomicNameCacheMap::const_iterator atomicNameCacheEnd = m_atomicNameCaches.end();
     for (NodeListAtomicNameCacheMap::const_iterator it = m_atomicNameCaches.begin(); it != atomicNameCacheEnd; ++it)
         it->value->invalidateCache(attrName);
 
     if (attrName)
         return;
 
     TagCollectionCacheNS::iterator tagCacheEnd = m_tagCollectionCacheNS.end();
     for (TagCollectionCacheNS::iterator it = m_tagCollectionCacheNS.begin(); it != tagCacheEnd; ++it)
         it->value->invalidateCache();
 }
 
+void NodeRareData::dispose()
+{
+#if ENABLE(OILPAN)

[haraken, 2014/04/21 06:00:34]

Ditto.

[sof, 2014/04/21 07:34:05]

Hmm, is it feasible to dispose early in the non-Oilpan case? I will have to look
into again.

[sof, 2014/04/21 12:45:16]

..as we have identified all the places where we have to explicitly dispose() in
the Oilpan case, also calling dispose() in the non-Oilpan case should be
complete, and consequently there is no need to call in dispose() in the
MutationObserverRegistration destructor. Done; i.e., removed the #if, here &
elsewhere.

+    if (m_mutationObserverData) {
+        for (unsigned i = 0; i < m_mutationObserverData->registry.size(); i++)
+            m_mutationObserverData->registry.at(i)->dispose();
+        m_mutationObserverData.clear();
+    }
+#endif
+}
+
 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow
 COMPILE_ASSERT(Page::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrameCountBits), Frame_limit_should_fit_in_rare_data_count);
 
 } // namespace WebCore