Oilpan: move mutation observers to the Oilpan heap.

Source/core/dom/NodeRareData.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/dom/NodeRareData.h"
 #include "core/dom/Element.h"
+#include "platform/heap/Handle.h"
 
 namespace WebCore {
 
 struct SameSizeAsNodeRareData {
     void* m_pointer[3];
+#if ENABLE(OILPAN)
+    // FIXME: Oilpan: when the persistent reference to NodeMutationObserverData goes,
+    // this can be removed.
+    void* m_extraOilpanPersistentPointers[sizeof(Persistent<NodeMutationObserverData>) / sizeof(void*) - 1];
+#endif

[haraken, 2014/04/15 02:33:25]

Can you simple write:

  OwnPtrWillBePersistent<NodeMutationObserverData> m_mutationObserverData;

?

[sof, 2014/04/15 22:00:53]

That's a good suggestion.

And as m_nodeLists is an OwnPtr<>, we will still verify that sizeof(OwnPtr<T>)
== sizeof(void*).

     unsigned m_bitfields;
 };
 
 COMPILE_ASSERT(sizeof(NodeRareData) == sizeof(SameSizeAsNodeRareData), NodeRareDataShouldStaySmall);
 
 void NodeListsNodeData::invalidateCaches(const QualifiedName* attrName)
 {
     NodeListAtomicNameCacheMap::const_iterator atomicNameCacheEnd = m_atomicNameCaches.end();
     for (NodeListAtomicNameCacheMap::const_iterator it = m_atomicNameCaches.begin(); it != atomicNameCacheEnd; ++it)
         it->value->invalidateCache(attrName);
 
     if (attrName)
         return;
 
     TagCollectionCacheNS::iterator tagCacheEnd = m_tagCollectionCacheNS.end();
     for (TagCollectionCacheNS::iterator it = m_tagCollectionCacheNS.begin(); it != tagCacheEnd; ++it)
         it->value->invalidateCache();
 }
 
+#if ENABLE(OILPAN)
+void NodeRareData::dispose()
+{
+    if (m_mutationObserverData) {
+        for (unsigned i = 0; i < m_mutationObserverData->registry.size(); i++)
+            m_mutationObserverData->registry.at(i)->dispose();
+        m_mutationObserverData.clear();
+    }
+}
+#endif
+
 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow
 COMPILE_ASSERT(Page::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrameCountBits), Frame_limit_should_fit_in_rare_data_count);
 
 } // namespace WebCore