Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2366523002: [tools] Add Group-Total-V8 category to callstats.py (Closed)

Created:
4 years, 3 months ago by Camillo Bruni
Modified:
4 years, 3 months ago
Reviewers:
nickie, Michael Hablich
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Add Group-Total-V8 category to callstats.py Group-Total-V8 contains all but Group-Callback times which should lead to more stable data. R=hablich@chromium.org NOTRY=true BUG= Committed: https://crrev.com/a9ed516ceb0c820475bed239da08bf1d80eb3353 Cr-Commit-Position: refs/heads/master@{#39668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M tools/callstats.py View 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Camillo Bruni
PTAL
4 years, 3 months ago (2016-09-23 12:16:13 UTC) #2
nickie
lgtm
4 years, 3 months ago (2016-09-23 12:20:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366523002/1
4 years, 3 months ago (2016-09-23 13:33:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 13:36:49 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 13:37:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9ed516ceb0c820475bed239da08bf1d80eb3353
Cr-Commit-Position: refs/heads/master@{#39668}

Powered by Google App Engine
This is Rietveld 408576698