Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2366493003: Simplify parse_certificate_fuzzer. (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 2 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, fuzzing_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify parse_certificate_fuzzer. Committed: https://crrev.com/abee8b631557f5d01a728b3d7e6416011cfb85e5 Cr-Commit-Position: refs/heads/master@{#420688}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -69 lines) Patch
M net/cert/internal/parse_certificate_fuzzer.cc View 1 1 chunk +6 lines, -69 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
eroman
4 years, 3 months ago (2016-09-22 07:09:48 UTC) #4
mattm
lgtm https://codereview.chromium.org/2366493003/diff/1/net/cert/internal/parse_certificate_fuzzer.cc File net/cert/internal/parse_certificate_fuzzer.cc (left): https://codereview.chromium.org/2366493003/diff/1/net/cert/internal/parse_certificate_fuzzer.cc#oldcode66 net/cert/internal/parse_certificate_fuzzer.cc:66: ParseCertificatePoliciesExtension(extension.value, &policies); Doesn't fuzz ParseCertificatePoliciesExtension and ParseEKUExtension extension ...
4 years, 2 months ago (2016-09-22 22:57:14 UTC) #7
eroman
https://codereview.chromium.org/2366493003/diff/1/net/cert/internal/parse_certificate_fuzzer.cc File net/cert/internal/parse_certificate_fuzzer.cc (left): https://codereview.chromium.org/2366493003/diff/1/net/cert/internal/parse_certificate_fuzzer.cc#oldcode66 net/cert/internal/parse_certificate_fuzzer.cc:66: ParseCertificatePoliciesExtension(extension.value, &policies); On 2016/09/22 22:57:14, mattm wrote: > Doesn't ...
4 years, 2 months ago (2016-09-22 23:22:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366493003/20001
4 years, 2 months ago (2016-09-23 18:59:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-23 19:10:18 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 19:12:26 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/abee8b631557f5d01a728b3d7e6416011cfb85e5
Cr-Commit-Position: refs/heads/master@{#420688}

Powered by Google App Engine
This is Rietveld 408576698