Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2366443005: Remove local copies of SuggestionsSource. (Closed)
Patch Set: Added ntp OWNERS to ntp tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
index 3aa1aaff9fe00afad5a4ec64ebff0e9379b2e62b..b1626a8cdf5ad551de77b6e0273d5424b2b64790 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
@@ -66,7 +66,6 @@ public class SnippetArticleViewHolder extends CardViewHolder implements Impressi
private static final int ID_REMOVE = 4;
private final NewTabPageManager mNewTabPageManager;
- private final SuggestionsSource mSuggestionsSource;
private final TextView mHeadlineTextView;
private final TextView mPublisherTextView;
private final TextView mArticleSnippetTextView;
@@ -154,11 +153,10 @@ public class SnippetArticleViewHolder extends CardViewHolder implements Impressi
* @param uiConfig The NTP UI configuration object used to adjust the article UI.
*/
public SnippetArticleViewHolder(NewTabPageRecyclerView parent, NewTabPageManager manager,
- SuggestionsSource suggestionsSource, UiConfig uiConfig) {
+ UiConfig uiConfig) {
super(R.layout.new_tab_page_snippets_card, parent, uiConfig);
mNewTabPageManager = manager;
- mSuggestionsSource = suggestionsSource;
mThumbnailView = (ImageView) itemView.findViewById(R.id.article_thumbnail);
mHeadlineTextView = (TextView) itemView.findViewById(R.id.article_headline);
mPublisherTextView = (TextView) itemView.findViewById(R.id.article_publisher);
@@ -286,7 +284,7 @@ public class SnippetArticleViewHolder extends CardViewHolder implements Impressi
public void onBindViewHolder(SnippetArticle article) {
super.onBindViewHolder();
- mArticle = (SnippetArticle) article;
+ mArticle = article;
updateLayout();
mHeadlineTextView.setText(mArticle.mTitle);
@@ -332,7 +330,8 @@ public class SnippetArticleViewHolder extends CardViewHolder implements Impressi
} else {
mThumbnailView.setImageResource(R.drawable.ic_snippet_thumbnail_placeholder);
mImageCallback = new FetchImageCallback(this, mArticle);
- mSuggestionsSource.fetchSuggestionImage(mArticle, mImageCallback);
+ mNewTabPageManager.getSuggestionsSource()
+ .fetchSuggestionImage(mArticle, mImageCallback);
}
}

Powered by Google App Engine
This is Rietveld 408576698