Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2366433003: [turbofan] Cleanup: Type only has a semantic dimension. (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Cleanup: Type only has a semantic dimension. BUG= Committed: https://crrev.com/648ac4405649e88a26d38b357f9494722e258ef0 Cr-Commit-Position: refs/heads/master@{#39666}

Patch Set 1 #

Patch Set 2 : Removed duplicate code. #

Patch Set 3 : REBASE. #

Total comments: 6

Patch Set 4 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -129 lines) Patch
M src/compiler/representation-change.cc View 1 2 3 8 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/types.h View 1 2 3 8 chunks +7 lines, -34 lines 0 comments Download
M src/compiler/types.cc View 1 2 3 26 chunks +40 lines, -82 lines 0 comments Download
M test/cctest/types-fuzz.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
mvstanton
Hi Jaro, Here is "part 2". Semantic is gone like wind.
4 years, 3 months ago (2016-09-22 19:12:01 UTC) #4
Jarin
lgtm https://codereview.chromium.org/2366433003/diff/40001/src/compiler/types.cc File src/compiler/types.cc (right): https://codereview.chromium.org/2366433003/diff/40001/src/compiler/types.cc#newcode917 src/compiler/types.cc:917: #define RETURN_NAMED_SEMANTIC_TYPE(type, value) \ RETURN_NAMED_TYPE? https://codereview.chromium.org/2366433003/diff/40001/src/compiler/types.h File src/compiler/types.h ...
4 years, 3 months ago (2016-09-23 09:23:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366433003/60001
4 years, 3 months ago (2016-09-23 11:07:14 UTC) #11
mvstanton
thanks! https://codereview.chromium.org/2366433003/diff/40001/src/compiler/types.cc File src/compiler/types.cc (right): https://codereview.chromium.org/2366433003/diff/40001/src/compiler/types.cc#newcode917 src/compiler/types.cc:917: #define RETURN_NAMED_SEMANTIC_TYPE(type, value) \ On 2016/09/23 09:23:39, Jarin ...
4 years, 3 months ago (2016-09-23 11:23:57 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-23 13:28:06 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 13:28:20 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/648ac4405649e88a26d38b357f9494722e258ef0
Cr-Commit-Position: refs/heads/master@{#39666}

Powered by Google App Engine
This is Rietveld 408576698