Adding error message to error string

chrome/browser/resources/google_now/utility.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview Utility objects and functions for Google Now extension.
  * Most important entities here:
  * (1) 'wrapper' is a module used to add error handling and other services to
@@ skipping 96 matching lines @@
     // topFrameElements is an array that ends like:
     // [N-3] //pmofbkohncoogjjhahejjfbppikbjigm/utility.js
     // [N-2] 308
     // [N-1] 19
     if (topFrameElements.length >= 3) {
       file = topFrameElements[topFrameElements.length - 3];
       line = topFrameElements[topFrameElements.length - 2];
     }
   }
 
+  var errorText = encodeURIComponent(error.name);
+  if (error.canSendMessageToServer)
+    errorText = errorText + ': ' + error.message;

[arv (Not doing code reviews), 2013/09/03 17:01:30]

What about the message? Is it already encoded?

[vadimt, 2013/09/03 17:58:44]

Gosh

+
   var requestParameters =
-      'error=' + encodeURIComponent(error.name) +
+      'error=' + errorText +
       '&script=' + encodeURIComponent(file) +
       '&line=' + encodeURIComponent(line) +
       '&trace=' + encodeURIComponent(filteredStack);
   var request = buildServerRequest('jserror',
                                    'application/x-www-form-urlencoded');
   request.onloadend = function(event) {
     console.log('sendErrorReport status: ' + request.status);
   };
   request.send(requestParameters);
 }
@@ skipping 593 matching lines @@
   // Poll for the sign in state every hour.
   // One hour is just an arbitrary amount of time chosen.
   chrome.alarms.create(alarmName, {periodInMinutes: 60});
 
   return {
     addListener: addListener,
     isSignedIn: isSignedIn,
     removeToken: removeToken
   };
 }