Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2366363003: [turbofan] Remove unsafe JSToBoolean lowering. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove unsafe JSToBoolean lowering. The lowering of {JSToBoolean} operators in {JSTypedLowering} inserts loads that are not part of the effect chain. This does not play well with effect-sensitive data flow analysis (e.g. escape analysis). This removes the lowering in question, we can implement it using a dedicated simplified operator eventually if needed. R=bmeurer@chromium.org TEST=mjsunit/wasm/embenchen/lua_binarytrees Committed: https://crrev.com/66e73b3a1b898787d3a3f79f4135e0047f296d2a Cr-Commit-Position: refs/heads/master@{#39773}

Patch Set 1 #

Patch Set 2 : Remove unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Michael Starzinger
4 years, 2 months ago (2016-09-27 12:05:58 UTC) #3
Benedikt Meurer
LGTM
4 years, 2 months ago (2016-09-27 12:17:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366363003/20001
4 years, 2 months ago (2016-09-27 13:52:30 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 13:55:09 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 13:55:34 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66e73b3a1b898787d3a3f79f4135e0047f296d2a
Cr-Commit-Position: refs/heads/master@{#39773}

Powered by Google App Engine
This is Rietveld 408576698