Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2366333004: Revert of clean up replace contents()->GetMainFrame() to main_test_rfh() (Closed)

Created:
4 years, 2 months ago by ncarter (slow)
Modified:
4 years, 2 months ago
Reviewers:
simonhong, zino, dhna
CC:
chromium-reviews, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of clean up replace contents()->GetMainFrame() to main_test_rfh() (patchset #6 id:100001 of https://codereview.chromium.org/2375583002/ ) Reason for revert: This patch is incorrect. |contents| and |contents()| are different objects. Original issue's description: > clean up replace contents()->GetMainFrame() to main_test_rfh() > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/721f96a79d8dbb6ab8ab3d4ae45f2219da100412 > Cr-Commit-Position: refs/heads/master@{#421303} TBR=jinho.bang@samsung.com,simonhong@chromium.org,corona10@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/19453cfc96f1ab5fd8161ecc5177df291e9740c9 Cr-Commit-Position: refs/heads/master@{#421361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ncarter (slow)
Created Revert of clean up replace contents()->GetMainFrame() to main_test_rfh()
4 years, 2 months ago (2016-09-27 22:23:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366333004/1
4 years, 2 months ago (2016-09-27 22:24:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 22:24:59 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 22:27:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19453cfc96f1ab5fd8161ecc5177df291e9740c9
Cr-Commit-Position: refs/heads/master@{#421361}

Powered by Google App Engine
This is Rietveld 408576698