cc/layers/picture_layer.cc - Issue 236633008: Switching Chromium to use new Skia SkPictureRecorder API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/picture_layer.cc

Issue 236633008: Switching Chromium to use new Skia SkPictureRecorder API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address code review issue Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/picture_layer.cc

diff --git a/cc/layers/picture_layer.cc b/cc/layers/picture_layer.cc

index e47f4b88d13e19d2992068bc06939abeab445031..2e1f0e14813aa56fa45276b504d424857b749397 100644

--- a/cc/layers/picture_layer.cc

+++ b/cc/layers/picture_layer.cc

@@ -186,10 +186,10 @@ skia::RefPtr<SkPicture> PictureLayer::GetPicture() const {

int height = bounds().height();

gfx::RectF opaque;

- skia::RefPtr<SkPicture> picture = skia::AdoptRef(new SkPicture);

- SkCanvas* canvas = picture->beginRecording(width, height);

+ SkPictureRecorder recorder;

+ SkCanvas* canvas = recorder.beginRecording(width, height);

client_->PaintContents(canvas, gfx::Rect(width, height), &opaque);

- picture->endRecording();

+ skia::RefPtr<SkPicture> picture = skia::AdoptRef(recorder.endRecording());

return picture;

}