Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 236633003: Issue 2031. Close omnibox's popup when Editor lost focus. (Closed)

Created:
6 years, 8 months ago by scheglov
Modified:
6 years, 8 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/omni/OmniBoxControlContribution.java View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 8 months ago (2014-04-13 20:34:47 UTC) #1
pquitslund
LGTM. I think this bears testing on windows and linux to be safe but I ...
6 years, 8 months ago (2014-04-14 03:47:26 UTC) #2
scheglov
6 years, 8 months ago (2014-04-14 05:27:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698