Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2366323003: Revert of Remove ref_counted.cc (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
dcheng, tzik
CC:
chromium-reviews, gavinp+memory_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove ref_counted.cc (patchset #4 id:60001 of https://codereview.chromium.org/2345013003/ ) Reason for revert: Increased Android .so by 50kb rather than shrinking it. Original issue's description: > Remove ref_counted.cc > > This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc > to the header as inline functions for smaller binary. > > RefCountedThreadSafe methods in ref_counted.cc are too small to have > non-inlined function. Inlining them to the caller reduces the stripped > binary size of Chromium on Linux by 84kB, since the binary size the > function body are even smaller than the binary size of the function > call itself. > > Committed: https://crrev.com/2c5c70912ccd80e712b18b4bf39f6da3d41e8847 > Cr-Commit-Position: refs/heads/master@{#419973} TBR=dcheng@chromium.org,tzik@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/05fcf0d42feafb79059173e37763d2ea8d25af64 Cr-Commit-Position: refs/heads/master@{#421047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -36 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/memory/ref_counted.h View 1 chunk +6 lines, -36 lines 0 comments Download
A base/memory/ref_counted.cc View 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
agrieve
Created Revert of Remove ref_counted.cc
4 years, 2 months ago (2016-09-26 18:17:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366323003/1
4 years, 2 months ago (2016-09-26 20:30:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 00:16:18 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 00:18:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05fcf0d42feafb79059173e37763d2ea8d25af64
Cr-Commit-Position: refs/heads/master@{#421047}

Powered by Google App Engine
This is Rietveld 408576698