third_party/WebKit/Source/core/css/PropertyRegistry.cpp - Issue 2366313006: CSS Properties and Values API: Support non-inherited custom properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/PropertyRegistry.cpp

Issue 2366313006: CSS Properties and Values API: Support non-inherited custom properties (Closed)

Patch Set: use de morgan's law Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/PropertyRegistry.cpp

diff --git a/third_party/WebKit/Source/core/css/PropertyRegistry.cpp b/third_party/WebKit/Source/core/css/PropertyRegistry.cpp

index c23bc1173f125d737e57c7edddcb5cd2fdb61764..e8d618703c36da81223cf2dd7aaeb33772f8f95a 100644

--- a/third_party/WebKit/Source/core/css/PropertyRegistry.cpp

+++ b/third_party/WebKit/Source/core/css/PropertyRegistry.cpp

@@ -9,8 +9,6 @@ namespace blink {

void PropertyRegistry::registerProperty(const AtomicString& name, const CSSSyntaxDescriptor& syntax, bool inherits, const CSSValue* initial, PassRefPtr<CSSVariableData> initialVariableData)

{

DCHECK(!registration(name));

- // TODO(timloh): We only support inherited properties for now.

- inherits = true;

m_registrations.set(name, new Registration(syntax, inherits, initial, initialVariableData));

}