Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2366313002: Revert "[turbofan] Cleanup: Type only has a semantic dimension." (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[turbofan] Cleanup: Type only has a semantic dimension." Reverted for stability reasons. BUG=chromium:649967 TBR=jarin@chromium.org Committed: https://crrev.com/a10c69f0934fce6aa31e95bed7e422eb00a59212 Cr-Commit-Position: refs/heads/master@{#39716}

Patch Set 1 #

Patch Set 2 : nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -53 lines) Patch
M src/compiler/representation-change.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M src/compiler/types.h View 1 8 chunks +31 lines, -5 lines 0 comments Download
M src/compiler/types.cc View 1 26 chunks +82 lines, -40 lines 0 comments Download
M test/cctest/types-fuzz.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366313002/1
4 years, 2 months ago (2016-09-26 11:12:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24970)
4 years, 2 months ago (2016-09-26 11:20:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366313002/20001
4 years, 2 months ago (2016-09-26 11:36:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 12:02:05 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a10c69f0934fce6aa31e95bed7e422eb00a59212 Cr-Commit-Position: refs/heads/master@{#39716}
4 years, 2 months ago (2016-09-26 12:02:25 UTC) #11
mvstanton
4 years, 2 months ago (2016-09-27 09:47:40 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2376653002/ by mvstanton@chromium.org.

The reason for reverting is: This was a revert for stability reasons. Now I
revert the revert!.

Powered by Google App Engine
This is Rietveld 408576698