Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2366303002: Only look at the last 10K samples for WebRTC muting tests. (Closed)

Created:
4 years, 2 months ago by phoglund_chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only look at the last 10K samples for WebRTC muting tests. Chrome has maybe gotten a bit slower at muting, but it's at most 1 sec. This test should not be a performance test of muting speed though, merely that muting happens, so update the test to just look at the last 10K samples in case we're unlucky and get a beep into the samples window before the mute kicks in. BUG=648879 R=ehmaldonado@chromium.org Committed: https://crrev.com/4589e9a6c8fa01dab372c1b35a149ceaed8215f1 Cr-Commit-Position: refs/heads/master@{#421139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M content/test/data/media/webrtc_test_audio.js View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
phoglund_chromium
4 years, 2 months ago (2016-09-26 09:27:05 UTC) #1
ehmaldonado_chromium
On 2016/09/26 09:27:05, phoglund_chrome_000_sep26 wrote: LGTM What was the number of samples before?
4 years, 2 months ago (2016-09-26 09:28:51 UTC) #2
phoglund_chromium
On 2016/09/26 09:28:51, ehmaldonado_chromium wrote: > On 2016/09/26 09:27:05, phoglund_chrome_000_sep26 wrote: > > LGTM > ...
4 years, 2 months ago (2016-09-26 12:56:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366303002/1
4 years, 2 months ago (2016-09-26 12:56:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148010)
4 years, 2 months ago (2016-09-26 15:25:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366303002/1
4 years, 2 months ago (2016-09-26 15:27:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148067)
4 years, 2 months ago (2016-09-26 19:21:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366303002/1
4 years, 2 months ago (2016-09-27 07:13:49 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 07:46:36 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 07:48:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4589e9a6c8fa01dab372c1b35a149ceaed8215f1
Cr-Commit-Position: refs/heads/master@{#421139}

Powered by Google App Engine
This is Rietveld 408576698