Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2009)

Issue 2366283002: Dash to use SkIsAlign2 (Closed)

Created:
4 years, 2 months ago by cblume
Modified:
4 years, 2 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Dash to use SkIsAlign2 Dash checks for alignment by actively aligning. It should really just check for alignment. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2366283002 Committed: https://skia.googlesource.com/skia/+/eafe9d1577f7a9feb19af9773bf835e5d657bec1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/effects/SkDashPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
cblume
PTAL
4 years, 2 months ago (2016-09-26 07:35:14 UTC) #5
mtklein
lgtm
4 years, 2 months ago (2016-09-26 11:18:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366283002/1
4 years, 2 months ago (2016-09-26 11:18:24 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 11:23:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eafe9d1577f7a9feb19af9773bf835e5d657bec1

Powered by Google App Engine
This is Rietveld 408576698