Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2366263002: Changed ECaptionSide to an enum class and renamed its members to keywords (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
index 838086cfea0dcb0a5bb8dee62eaad7e4b66904d1..adba1ae9a826634389f0cf0db75af99bf0e0dd47 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
@@ -964,16 +964,16 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ECaptionSide e)
{
init(UnitType::ValueID);
switch (e) {
- case CaptionSideLeft:
+ case ECaptionSide::Left:
m_value.valueID = CSSValueLeft;
break;
- case CaptionSideRight:
+ case ECaptionSide::Right:
m_value.valueID = CSSValueRight;
break;
- case CaptionSideTop:
+ case ECaptionSide::Top:
m_value.valueID = CSSValueTop;
break;
- case CaptionSideBottom:
+ case ECaptionSide::Bottom:
m_value.valueID = CSSValueBottom;
break;
}
@@ -984,19 +984,19 @@ template<> inline ECaptionSide CSSPrimitiveValue::convertTo() const
ASSERT(isValueID());
switch (m_value.valueID) {
case CSSValueLeft:
- return CaptionSideLeft;
+ return ECaptionSide::Left;
case CSSValueRight:
- return CaptionSideRight;
+ return ECaptionSide::Right;
case CSSValueTop:
- return CaptionSideTop;
+ return ECaptionSide::Top;
case CSSValueBottom:
- return CaptionSideBottom;
+ return ECaptionSide::Bottom;
default:
break;
}
ASSERT_NOT_REACHED();
- return CaptionSideTop;
+ return ECaptionSide::Top;
}
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EClear e)
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTable.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698