third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 2366253002: Remove ActiveDOMObject::stop()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 2366253002: Remove ActiveDOMObject::stop() (Closed)

Patch Set: temp Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

index edbe997e4110d568870883fd450b754a2b07eaa5..0929fb99334ca56de75f6bb99bdb1ec0b57f819f 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

@@ -84,7 +84,7 @@ class ServiceWorkerRegistration final

void dispose();

// ActiveDOMObject overrides.

- void stop() override;

+ void contextDestroyed() override;

// A handle to the registration representation in the embedder.

std::unique_ptr<WebServiceWorkerRegistration::Handle> m_handle;